Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Porting #51954 to master #54603

Merged
merged 5 commits into from Jan 2, 2020

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 19, 2019

Porting #51954 to master

@garethgreenaway garethgreenaway requested a review from a team September 19, 2019 00:24
@ghost ghost requested review from dwoz and removed request for a team September 19, 2019 00:24
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #51954 to 2019.2.1 [master] Porting #51954 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:48
@waynew waynew added this to PR needs merge to master in PRs to port to master Oct 17, 2019
@garethgreenaway garethgreenaway requested a review from a team as a code owner December 3, 2019 18:50
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #54603 into master will decrease coverage by 3.99%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #54603      +/-   ##
==========================================
- Coverage   40.23%   36.23%      -4%     
==========================================
  Files        1481     1577      +96     
  Lines      260660   270228    +9568     
  Branches    56326    57613    +1287     
==========================================
- Hits       104871    97916    -6955     
- Misses     143730   161184   +17454     
+ Partials    12059    11128     -931
Flag Coverage Δ
#amazon2 ?
#archlts ?
#centos7 36.23% <50%> (-3.05%) ⬇️
#centos8 ?
#cloud ?
#debian10 ?
#debian8 ?
#debian9 ?
#fedora30 ?
#m2crypto ?
#opensuse15 ?
#proxy ?
#py2 ?
#py3 36.23% <50%> (-3.52%) ⬇️
#pycryptodomex ?
#runtests ?
#salt ?
#tcp ?
#tests ?
#tornado ?
#ubuntu1604 ?
#ubuntu1804 ?
#windows2016 ?
#zeromq 36.23% <50%> (-3.06%) ⬇️
Impacted Files Coverage Δ
salt/modules/linux_lvm.py 72.76% <50%> (-0.94%) ⬇️
salt/ext/vsan/vsanmgmtObjects.py 0% <0%> (-100%) ⬇️
salt/utils/vsan.py 13.3% <0%> (-83.03%) ⬇️
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/ext/ipaddress.py 0% <0%> (-48.65%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
... and 457 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c9426...8f0b9f3. Read the comment docs.

@garethgreenaway
Copy link
Contributor Author

Requires #54611

@dwoz dwoz merged commit 2953d55 into saltstack:master Jan 2, 2020
PRs to port to master automation moved this from PR needs merge to master to PR merged Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants