Add virt.pool_capabilities function#55346
Merged
dwoz merged 2 commits intosaltstack:masterfrom Dec 27, 2019
Merged
Conversation
ghost
requested a review
from 
cbosdo
force-pushed
the
master-pool-capabilities
branch
3 times, most recently
from
34f6496 to
cb687a4
Compare
Akm0d
added
the
Feature
Contributor
|
@cbosdo Can you please resolve the merge conflict? |
cbosdo
force-pushed
the
master-pool-capabilities
branch
from
cb687a4 to
5dabfad
Compare
Contributor
Author
done |
cbosdo
force-pushed
the
master-pool-capabilities
branch
from
5dabfad to
0fd036f
Compare
cbosdo
force-pushed
the
master-pool-capabilities
branch
2 times, most recently
from
f4a627a to
b178aa4
Compare
Contributor
Author
|
rebased on master |
cbosdo
force-pushed
the
master-pool-capabilities
branch
from
73e03fd to
86b18b8
Compare
Contributor
Author
|
rebased on master |
cbosdo
force-pushed
the
master-pool-capabilities
branch
from
bac9eed to
f965145
Compare
Not all storage backends are supported for a given libvirt hypervisor. For the user to know what is supported and what is not expose the recently added libvirt function providing pool capabilities. For older libvirt version, let's craft data that are reasonable by adding a computed flag to warn these data may not be 100% accurate.
cbosdo
force-pushed
the
master-pool-capabilities
branch
from
f965145 to
7850656
Compare
dwoz
approved these changes
Dec 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.
For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.
What issues does this PR fix or reference?
Tests written?
Yes
Commits signed with GPG?
Yes