Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virt.pool_capabilities function #55346

Merged
merged 2 commits into from Dec 27, 2019
Merged

Conversation

cbosdo
Copy link
Collaborator

@cbosdo cbosdo commented Nov 18, 2019

What does this PR do?

Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.

For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.

What issues does this PR fix or reference?

Tests written?

Yes

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from as a code owner Nov 18, 2019
@ghost ghost requested a review from dwoz Nov 18, 2019
@cbosdo cbosdo force-pushed the master-pool-capabilities branch 3 times, most recently from 34f6496 to cb687a4 Compare Nov 18, 2019
@Akm0d Akm0d added the Feature label Nov 20, 2019
@Akm0d Akm0d added this to the Approved milestone Nov 20, 2019
@Akm0d Akm0d added this to Backlog in Neon Nov 20, 2019
@dwoz
Copy link
Contributor

@dwoz dwoz commented Dec 2, 2019

@cbosdo Can you please resolve the merge conflict?

@cbosdo cbosdo force-pushed the master-pool-capabilities branch from cb687a4 to 5dabfad Compare Dec 3, 2019
@cbosdo
Copy link
Collaborator Author

@cbosdo cbosdo commented Dec 3, 2019

@cbosdo Can you please resolve the merge conflict?

done

@cbosdo cbosdo force-pushed the master-pool-capabilities branch from 5dabfad to 0fd036f Compare Dec 6, 2019
@cbosdo cbosdo force-pushed the master-pool-capabilities branch 2 times, most recently from f4a627a to b178aa4 Compare Dec 20, 2019
@cbosdo
Copy link
Collaborator Author

@cbosdo cbosdo commented Dec 20, 2019

rebased on master

@cbosdo cbosdo force-pushed the master-pool-capabilities branch from 73e03fd to 86b18b8 Compare Dec 23, 2019
@cbosdo
Copy link
Collaborator Author

@cbosdo cbosdo commented Dec 23, 2019

rebased on master

@cbosdo cbosdo force-pushed the master-pool-capabilities branch from bac9eed to f965145 Compare Dec 26, 2019
Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.

For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.
@cbosdo cbosdo force-pushed the master-pool-capabilities branch from f965145 to 7850656 Compare Dec 26, 2019
dwoz
dwoz approved these changes Dec 27, 2019
@dwoz dwoz merged commit 026f136 into saltstack:master Dec 27, 2019
49 checks passed
@cbosdo cbosdo deleted the master-pool-capabilities branch Dec 30, 2019
@sagetherage sagetherage moved this from Backlog to Done in Neon Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature
Projects
No open projects
Neon
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants