Fix service.reload in gentoo_service module#55452
Merged
Merged
Conversation
ghost
requested a review
from 
dwoz
approved these changes
Dec 2, 2019
Contributor
Author
|
@dwoz done. |
dwoz
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes gentoo_service.py module.
What issues does this PR fix or reference?
gentoo_service module has reload_ function but service.reload doesn't work because there is no 'reload' alias defined.
Tests written?
I believe the existing tests are enough for such changes.
Commits signed with GPG?
Yes