Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTest #27] When running under PyTest, use pytest.mark.skipif instead #55536

Merged
merged 4 commits into from
Dec 12, 2019

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

See title

@s0undt3ch s0undt3ch requested a review from a team as a code owner December 5, 2019 19:13
@ghost ghost requested a review from garethgreenaway December 5, 2019 19:13
@s0undt3ch s0undt3ch force-pushed the features/pytest-staged-27 branch 7 times, most recently from f4ef8cd to f3f0272 Compare December 9, 2019 10:13
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #55536 into master will decrease coverage by 0.73%.
The diff coverage is 9.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #55536      +/-   ##
==========================================
- Coverage   18.78%   18.05%   -0.72%     
==========================================
  Files         816      785      -31     
  Lines      174955   169258    -5697     
  Branches    37562    36349    -1213     
==========================================
- Hits        32845    30544    -2301     
+ Misses     139436   136570    -2866     
+ Partials     2674     2144     -530
Flag Coverage Δ
#archlts 18.05% <9.49%> (ø) ⬇️
#centos7 ?
#proxy ?
#py2 17.85% <9.49%> (-0.72%) ⬇️
#py3 17.7% <9.49%> (-0.7%) ⬇️
#runtests 18.05% <9.49%> (-0.72%) ⬇️
#ubuntu1604 ?
#zeromq 18.05% <9.49%> (-0.72%) ⬇️
Impacted Files Coverage Δ
salt/modules/status.py 6.58% <0%> (-0.01%) ⬇️
salt/minion.py 16.48% <0%> (-3.76%) ⬇️
salt/auth/__init__.py 14.53% <0%> (-0.07%) ⬇️
salt/modules/beacons.py 7.27% <0%> (-0.56%) ⬇️
salt/utils/event.py 38.06% <50%> (+0.27%) ⬆️
salt/client/__init__.py 24.03% <9.1%> (+0.01%) ⬆️
salt/modules/dummyproxy_service.py 46.16% <0%> (-35.89%) ⬇️
salt/modules/dummyproxy_pkg.py 38.64% <0%> (-22.72%) ⬇️
salt/log/setup.py 25.84% <0%> (-21.18%) ⬇️
salt/utils/parsers.py 28.44% <0%> (-14.85%) ⬇️
... and 93 more

1 similar comment
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #55536 into master will decrease coverage by 0.73%.
The diff coverage is 9.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #55536      +/-   ##
==========================================
- Coverage   18.78%   18.05%   -0.72%     
==========================================
  Files         816      785      -31     
  Lines      174955   169258    -5697     
  Branches    37562    36349    -1213     
==========================================
- Hits        32845    30544    -2301     
+ Misses     139436   136570    -2866     
+ Partials     2674     2144     -530
Flag Coverage Δ
#archlts 18.05% <9.49%> (ø) ⬇️
#centos7 ?
#proxy ?
#py2 17.85% <9.49%> (-0.72%) ⬇️
#py3 17.7% <9.49%> (-0.7%) ⬇️
#runtests 18.05% <9.49%> (-0.72%) ⬇️
#ubuntu1604 ?
#zeromq 18.05% <9.49%> (-0.72%) ⬇️
Impacted Files Coverage Δ
salt/modules/status.py 6.58% <0%> (-0.01%) ⬇️
salt/minion.py 16.48% <0%> (-3.76%) ⬇️
salt/auth/__init__.py 14.53% <0%> (-0.07%) ⬇️
salt/modules/beacons.py 7.27% <0%> (-0.56%) ⬇️
salt/utils/event.py 38.06% <50%> (+0.27%) ⬆️
salt/client/__init__.py 24.03% <9.1%> (+0.01%) ⬆️
salt/modules/dummyproxy_service.py 46.16% <0%> (-35.89%) ⬇️
salt/modules/dummyproxy_pkg.py 38.64% <0%> (-22.72%) ⬇️
salt/log/setup.py 25.84% <0%> (-21.18%) ⬇️
salt/utils/parsers.py 28.44% <0%> (-14.85%) ⬇️
... and 93 more

@s0undt3ch s0undt3ch force-pushed the features/pytest-staged-27 branch 4 times, most recently from a84b87b to 72beb8e Compare December 10, 2019 14:45
@dwoz dwoz merged commit ef0471f into saltstack:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants