Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt/runner: respect --timeout argument when using eauth #55915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

salt/runner: respect --timeout argument when using eauth #55915

wants to merge 2 commits into from

Conversation

eliasp
Copy link
Contributor

@eliasp eliasp commented Jan 19, 2020 •
edited

When using external authentication, the --timeout argument for salt-run had no effect.

What does this PR do?

It makes the --timeout argument for salt-run work once again in setups using external authentication.

What issues does this PR fix or reference?

None

Previous Behavior

Specifying --timeout on the CLI when using salt-run had no effect at all.

New Behavior

--timeout is now respected again

Tests written?

Yes

Commits signed with GPG?

Yes

@eliasp eliasp force-pushed the master.salt-run-eauth-timeout branch 7 times, most recently from fc7e410 to e3e03b1 Compare January 20, 2020 09:46
@dwoz
Copy link
Contributor

dwoz commented Jan 21, 2020

@eliasp Looks like multiple test suites are failing https://jenkinsci.saltstack.com/job/pr-opensuse15-py2/job/PR-55915/8/

@eliasp eliasp force-pushed the master.salt-run-eauth-timeout branch from e3e03b1 to a599c04 Compare February 3, 2020 09:51
@eliasp eliasp force-pushed the master.salt-run-eauth-timeout branch from a599c04 to 2c72447 Compare May 9, 2020 19:37
@eliasp eliasp force-pushed the master.salt-run-eauth-timeout branch from 2c72447 to 3c4567b Compare May 25, 2020 20:22
@eliasp eliasp force-pushed the master.salt-run-eauth-timeout branch from 3c4567b to e7a00b3 Compare July 6, 2020 13:32
@eliasp
Copy link
Contributor Author

eliasp commented Jul 6, 2020

Anyone willing to take a stab at the tests? Can't figure out right now what's actually wrong and don't have much time to spare to dive into this again...

@eliasp eliasp force-pushed the master.salt-run-eauth-timeout branch 3 times, most recently from fe8b621 to 0cfe0f4 Compare May 25, 2023 09:34
@eliasp
Copy link
Contributor Author

eliasp commented May 25, 2023

I rebased this PR on current master, tests look good on my local box.
As I won't be involved with SaltStack in the foreseeable future, feel free to pick up the current branch to move forward with this PR.

@dwoz
Copy link
Contributor

dwoz commented Dec 12, 2023

@eliasp Is this still something you would like to get in?

@dwoz dwoz added this to the Argon v3008.0 milestone Dec 12, 2023
@eliasp
Copy link
Contributor Author

eliasp commented Dec 12, 2023

Since I'm not using Salt anymore, unfortunately I can't dedicate any time to work on related PRs.

Feel free to either pick it up from here, since the change is quite trivial or close it and keep the bug.

@dwoz dwoz self-assigned this Dec 16, 2023
@dwoz dwoz marked this pull request as ready for review December 16, 2023 00:00
@dwoz dwoz requested a review from a team as a code owner December 16, 2023 00:00
@dwoz dwoz requested review from twangboy and removed request for a team December 16, 2023 00:00
eliasp and others added 2 commits December 15, 2023 17:02
@eliasp @dwoz
salt/runner: respect --timeout argument when using eauth
41cda93 
When using external authentication, the `--timeout` argument for `salt-run` had no effect.
@dwoz
Fix tests
b661950
@dwoz dwoz force-pushed the master.salt-run-eauth-timeout branch from 0cfe0f4 to b661950 Compare December 16, 2023 00:57
@dwoz
Copy link
Contributor

dwoz commented Dec 16, 2023

@eliasp I've rebased the changes and got the tests into a state where they run. However, they tests are failing and by the looks of the failures the timeout doesn't seem to be getting honored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy Awaiting requested review from twangboy twangboy is a code owner automatically assigned from saltstack/team-core

At least 1 approving review is required to merge this pull request.

Assignees

@dwoz dwoz

Labels
has-failing-test
Projects
None yet
Milestone
Argon v3008.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliasp @dwoz