Merged
Conversation
Contributor
Author
|
@DmitryKuzmenko don't spend too much time reviewing that PR for the while: the code is still subject to changes |
Contributor
Author
|
@dwoz Don't loose time to blacken this PR for the while: code it still subject to changes: I'll handle the blackening before removing the WIP flag. |
cbosdo
force-pushed
the
virt-init-disks
branch
9 times, most recently
from
364b63a to
4e3f391
Compare
cbosdo
force-pushed
the
virt-init-disks
branch
3 times, most recently
from
f429f99 to
2ed480d
Compare
cbosdo
force-pushed
the
virt-init-disks
branch
2 times, most recently
from
6f01327 to
55097b7
Compare
Contributor
Author
|
@DmitryKuzmenko This PR is ready for review now |
Contributor
|
@cbosdo Looks like we got some test failures on Windows |
Contributor
Author
|
@twangboy should be fixed with the latest push... sadly |
Contributor
Author
|
All green now :) |
DmitryKuzmenko
previously approved these changes
May 6, 2020
In the near future gen_vol_xml will be able to handle many volume types, not only for ESX volumes. For this, clean up the function from all the ESX-specifics code and move them to the caller code. The volume key and target path values have also been removed since those are read-only elements that should not be provided for volume creation as per https://libvirt.org/formatstorage.html#StorageVol
In order to generate almost all the volumes that libvirt can handle, add the type, backingStore, permissions and allocation parameters to the virt._gen_vol_xml() function. Also make the format parameter optional since libvirt has default values depending on the storage backend.
In order to avoid connection multiple times when reusing this function in the virt module, create _define_vol_xml_str not caring about the connection opening and closing.
In the same vein than pool_define and network_define, expose a volume_define function to let users create a volume without needing to know all of libvirt's XML details.
When using volumes the user can just copy the template disk image into the target path. In such a case, the image needs to be uploaded into the volume.
Extract the libvirt-handling code from virt.capabilities into a virt._capabilities function accepting an opened libvirt connection. This allows reusing the code in other functions with easy connection handling.
Te virt.pool_capabilities function computes a lot of interesting values on the virtual storage pool types. Extract the logic of it into virt._pool_capabilities for reuse.
Since the next commits will introduce more uses of the libvirt connection in virt.init(), start sharing it now.
In order to support creating VMs with disk on more storage pools like iSCSI, disks, LVM, RBD, etc, virt.init needs to handle disks not only as files, but also as libvirt volumes.
libvirtError is not defined, libvirt.libvirtError should be used instead.
There is no need to generate MAC addresses in the virt module if the user hasn't provided any. This only makes it harder to make the difference between a real mac address change from the user and a new generated one. Now the mac address is not written in the domain XML definition if not provided by the user. This avoids unnecessary changes when applying virt.running.
Since it could be useful to know whether a volume has a backing store, output the path and format of the backing store if any is defined.
Since the format of a volume may be of interest and could help to tell if two volumes are similar, output this information in the virt.volume_infos function.
In order to help creating storage volumes in virtual storage pools from states, add a virt.volume_defined state.
If a virtual machine has disks of volume types, they will now be reported by the virt._get_disk() function and all the user-exposed functions using it like virt.get_disks(), virt.vm_info() and virt.full_info().
virt.purge will now remove not only the file disks, but also the disk volumes.
libvirt doesn't support attaching RBD storage pool volumes to a VM.
For instance, a disk with such a source is invalid:
<source pool='rbd-pool' volume='rbd-volume'/>
And needs to be replaced with:
<source protocol="rbd" name="rbd-pool-name/rbd-volume">
<host name="hostname" port="7000"/>
<auth username='myuser'>
<secret type='ceph' usage='mypassid'/>
</auth>
</source>
This means that we need to fetch the connection data from the pool
definition and convert the volume disk definition into a network one
when creating the VM.
This also means that when purging the VM we need to search for the
pool by looking in every pool's XML to delete the volume.
Since volumes in a virtual storage pool of type 'disk' are partitions, then need to be named after the disk name with sequential numbers rather than using the VM and disk names. Also, the format passed by the user is the one used when creating the volume. However in the VM definition for logical and disk volumes, the format should be set to raw.
Libvirt allows to use network images for cdroms. Use them if the image is a remote URL for a cdrom device.
Live attaching / detaching removable devices results in failures. To change the source of those, we need to call updateDeviceFlags instead.
dwoz
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables volume support in virt module and states.
What issues does this PR fix or reference?
Fixes: #57005
Previous Behavior
virt.running,virt.purge, etc could only handle file disk images.New Behavior
virt.running,virt.purge, etc can also handle volume disk images. This allows to use RBD, iSCSI, etc volumes in VMs.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes