New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return pip binary without -m flag when using onedir #56988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep functionality as it was and provide an alternate logic if the app is frozen and/or has the sys._MEIPASS
attribute?
@s0undt3ch I'm open to taking this in a different direction. The heart of the issue is that the executable that sys.executable is reporting is not python, just something else; in the case of the onedir it's |
Sure, and we should handle that. Draw your own conclusions and solution when running under pyinstaller. Makes sense? |
|
What does this PR do?
When using the onedir inside dist/run from pop-build, pip is provided and therefore cannot handle the -m flag. The pip module needs to handle this case.
What issues does this PR fix or reference?
Fixes:
https://github.com/saltstack/release-planning/issues/239
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.