Repository navigation
Return pip binary without -m flag when using onedir - #56988
Merged
Merged
Conversation
s0undt3ch
reviewed
Apr 30, 2020
s0undt3ch
left a comment
Contributor
There was a problem hiding this comment.
Should we keep functionality as it was and provide an alternate logic if the app is frozen and/or has the sys._MEIPASS attribute?
Contributor
Author
|
@s0undt3ch I'm open to taking this in a different direction. The heart of the issue is that the executable that sys.executable is reporting is not python, just something else; in the case of the onedir it's |
Contributor
|
Sure, and we should handle that. Draw your own conclusions and solution when running under pyinstaller. Makes sense? |
Contributor
|
s0undt3ch
reviewed
May 6, 2020
s0undt3ch
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using the onedir inside dist/run from pop-build, pip is provided and therefore cannot handle the -m flag. The pip module needs to handle this case.
What issues does this PR fix or reference?
Fixes:
https://github.com/saltstack/release-planning/issues/239
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.