Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master port of #50109 #57010

Merged
merged 1 commit into from May 1, 2020
Merged

Master port of #50109 #57010

merged 1 commit into from May 1, 2020

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Apr 30, 2020

What does this PR do?

Master port of the missing commit from PR #50109

What issues does this PR fix or reference?

Fixes: #57009

Merge requirements satisfied?

  • Docs
  • Changelog
  • Tests written/updated

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from a team as a code owner April 30, 2020 15:24
@ghost ghost requested review from waynew and removed request for a team April 30, 2020 15:24
In order to get all possible capabilities from a host, the user has to
call virt.capabilities, and then loop over the guests and domains
before calling virt.domain_capabilities for each of them.

This commit embeds all this logic to get them all in a single
virt.all_capabilities call.
@twangboy
Copy link
Contributor

Looks like a test failed on ubuntu 20.04. I restarted the test to see if it was just flacky... though it seems unrelated to the changes here. You may need to rebase.

@dwoz dwoz merged commit 47f6194 into saltstack:master May 1, 2020
@cbosdo cbosdo deleted the 50109-master-port branch May 2, 2020 13:48
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to Done in Sodium May 18, 2020
@max-arnold
Copy link
Contributor

@frogunder domain_capabilities has versionadded:: 2019.2.0. Should be 3001 instead.

Maybe it makes sense to run git diff between 3000.3 and master and grep for versionadded to see if there are more issues like this caused by the porting process. Also worth checking for missing versionadded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

virt: get hypervisor and domain capabilities in one shot
5 participants