Ensure errors are returned for missing pillars #57208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
@lnattrass Thanks for the PR! Looks like there are some small lint issues with the new tests you added, extra white space at the end of the lines. |
|
There sure are! |
|
Ok, I've resolved the lint issues (pending what the tests say..) |
This will cause render_pstate to return an error when the pillar is not found. Currently, missing pillars are silently continued, which may lead to unexpected pillar states (and makes testing the existence of pillars difficult.)
dwoz
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that errors are returned when including from a pillar like this:
What issues does this PR fix or reference?
Fixes: This PR
Previous Behavior
Salt 2018.3.5 returns errors when a pillar is not found.
Newer versions currently do not.
New Behavior
Salt returns errors when pillars fail to render
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.