Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grain.delkey grains.delval for nested keys #57235

Merged
merged 3 commits into from
May 20, 2020
Merged

Fix grain.delkey grains.delval for nested keys #57235

merged 3 commits into from
May 20, 2020

Conversation

owmtia
Copy link
Contributor

@owmtia owmtia commented May 13, 2020

What does this PR do?

Changes delval to use set instead of setval and delkey now uses
delval with destructive=true.

Adds test for deleting grains both nested and single keys.

What issues does this PR fix or reference?

Fixes #54819

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Fixes #54819

Changes delval to use set instead of setval and delkey now uses
delval with destructive=true.

Adds test for deleting grains both nested and single keys.
@owmtia owmtia requested a review from a team as a code owner May 13, 2020 04:35
@ghost ghost requested review from garethgreenaway and removed request for a team May 13, 2020 04:35
@dwoz dwoz merged commit b45b277 into saltstack:master May 20, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 20, 2020
@sagetherage sagetherage added this to In progress in Sodium via automation May 20, 2020
@sagetherage sagetherage moved this from In progress to Done in Sodium May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

neither grains.delkey nor grains.delval destructive=True work
3 participants