Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COPR support to states.pkgrepo #57259

Merged
merged 2 commits into from Sep 25, 2020
Merged

Add COPR support to states.pkgrepo #57259

merged 2 commits into from Sep 25, 2020

Conversation

mymindstorm
Copy link
Contributor

What does this PR do?

Adds a COPR option to pkgrepo.absent and pkgrepo.managed. This is a shortcut for either manually downloading the repo file or using cmd.run to add the COPR repository.

What issues does this PR fix or reference?

Fixes #57258

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

I'm new to Python, I might be missing a few things in the code.

@mymindstorm mymindstorm requested a review from a team as a code owner May 14, 2020 00:59
@ghost ghost requested review from waynew and removed request for a team May 14, 2020 00:59
waynew
waynew previously approved these changes May 18, 2020
@waynew
Copy link
Contributor

waynew commented May 18, 2020

Hey @mymindstorm thanks for the PR! Looks reasonable to me!

@mymindstorm
Copy link
Contributor Author

Looks like tests didn't actually run when I made this for some reason. I almost messed up pkgrepo on RedHat based computers.

@mymindstorm
Copy link
Contributor Author

Test failures seem to be unrelated? I'm not really sure what to make of the new ones that popped up.

@dwoz
Copy link
Contributor

dwoz commented May 20, 2020

re-run full all

@waynew
Copy link
Contributor

waynew commented May 27, 2020

re-run windows2016-py3

waynew
waynew previously approved these changes May 28, 2020
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this is 👍 but the Windows test is extremely unhappy here.

@mymindstorm
Copy link
Contributor Author

Do I need to do anything to get this merged? None of this should even execute on Windows...

@sagetherage sagetherage added Magnesium Mg release after Na prior to Al Feature new functionality including changes to functionality and code refactors, etc. labels Jul 22, 2020
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small request and if you could rebase.

salt/states/pkgrepo.py Show resolved Hide resolved
salt/states/pkgrepo.py Show resolved Hide resolved
Ch3LL
Ch3LL previously approved these changes Sep 9, 2020
@Ch3LL
Copy link
Contributor

Ch3LL commented Sep 15, 2020

looks like pre-commit is just failing. then we can get this in

@sagetherage
Copy link
Contributor

@mymindstorm here are the docs on pre-commit in case that is helpful : )

@mymindstorm
Copy link
Contributor Author

@mymindstorm here are the docs on pre-commit in case that is helpful : )

Thanks for the link, I don't have that much time to fix (and properly rebase) it right now. I will see if I can get to it this weekend.

dwoz
dwoz approved these changes Sep 25, 2020
@dwoz dwoz merged commit fbdf475 into saltstack:master Sep 25, 2020
26 checks passed
@welcome
Copy link

welcome bot commented Sep 25, 2020

Congratulations on your first PR being merged! 🎉

dwoz pushed a commit that referenced this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] COPR support in pkgrepo
5 participants