Skip to content

Add COPR support to states.pkgrepo - #57259

Merged
dwoz merged 2 commits into
saltstack:masterfrom
mymindstorm:copr
Sep 25, 2020
Merged

Add COPR support to states.pkgrepo#57259
dwoz merged 2 commits into
saltstack:masterfrom
mymindstorm:copr

Conversation

@mymindstorm

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a COPR option to pkgrepo.absent and pkgrepo.managed. This is a shortcut for either manually downloading the repo file or using cmd.run to add the COPR repository.

What issues does this PR fix or reference?

Fixes #57258

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

I'm new to Python, I might be missing a few things in the code.

@mymindstorm
mymindstorm requested a review from a team as a code owner May 14, 2020 00:59
@ghost
ghost requested review from waynew and removed request for a team May 14, 2020 00:59
waynew
waynew previously approved these changes May 18, 2020
@waynew

waynew commented May 18, 2020

Copy link
Copy Markdown
Contributor

Hey @mymindstorm thanks for the PR! Looks reasonable to me!

@mymindstorm

Copy link
Copy Markdown
Contributor Author

Looks like tests didn't actually run when I made this for some reason. I almost messed up pkgrepo on RedHat based computers.

@mymindstorm
mymindstorm force-pushed the copr branch 2 times, most recently from d171e60 to ea7c4dc Compare May 19, 2020 14:26
@mymindstorm
mymindstorm requested a review from waynew May 19, 2020 21:20
@mymindstorm

Copy link
Copy Markdown
Contributor Author

Test failures seem to be unrelated? I'm not really sure what to make of the new ones that popped up.

@dwoz

dwoz commented May 20, 2020

Copy link
Copy Markdown
Contributor

re-run full all

@waynew

waynew commented May 27, 2020

Copy link
Copy Markdown
Contributor

re-run windows2016-py3

waynew
waynew previously approved these changes May 28, 2020

@waynew waynew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this is 👍 but the Windows test is extremely unhappy here.

@mymindstorm

Copy link
Copy Markdown
Contributor Author

Do I need to do anything to get this merged? None of this should even execute on Windows...

@sagetherage sagetherage added Magnesium Mg release after Na prior to Al Feature new functionality including changes to functionality and code refactors, etc. labels Jul 22, 2020

@Ch3LL Ch3LL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small request and if you could rebase.

Comment thread salt/states/pkgrepo.py Outdated
Comment thread salt/states/pkgrepo.py Outdated
Ch3LL
Ch3LL previously approved these changes Sep 9, 2020
@Ch3LL

Ch3LL commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

looks like pre-commit is just failing. then we can get this in

@sagetherage

Copy link
Copy Markdown
Contributor

@mymindstorm here are the docs on pre-commit in case that is helpful : )

@mymindstorm

Copy link
Copy Markdown
Contributor Author

@mymindstorm here are the docs on pre-commit in case that is helpful : )

Thanks for the link, I don't have that much time to fix (and properly rebase) it right now. I will see if I can get to it this weekend.

@mymindstorm
mymindstorm requested a review from Ch3LL September 25, 2020 18:55
@dwoz
dwoz merged commit fbdf475 into saltstack:master Sep 25, 2020
@welcome

welcome Bot commented Sep 25, 2020

Copy link
Copy Markdown

Congratulations on your first PR being merged! 🎉

dwoz pushed a commit that referenced this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature new functionality including changes to functionality and code refactors, etc. Magnesium Mg release after Na prior to Al

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] COPR support in pkgrepo

5 participants