-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add COPR support to states.pkgrepo #57259
Conversation
Hey @mymindstorm thanks for the PR! Looks reasonable to me! |
Looks like tests didn't actually run when I made this for some reason. I almost messed up pkgrepo on RedHat based computers. |
d171e60
to
ea7c4dc
Compare
Test failures seem to be unrelated? I'm not really sure what to make of the new ones that popped up. |
re-run full all |
re-run windows2016-py3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, this is 👍 but the Windows test is extremely unhappy here.
Do I need to do anything to get this merged? None of this should even execute on Windows... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small request and if you could rebase.
looks like pre-commit is just failing. then we can get this in |
@mymindstorm here are the docs on pre-commit in case that is helpful : ) |
Thanks for the link, I don't have that much time to fix (and properly rebase) it right now. I will see if I can get to it this weekend. |
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Adds a COPR option to
pkgrepo.absent
andpkgrepo.managed
. This is a shortcut for either manually downloading the repo file or using cmd.run to add the COPR repository.What issues does this PR fix or reference?
Fixes #57258
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
I'm new to Python, I might be missing a few things in the code.