Merged
Conversation
ghost
requested review from
Contributor
Author
|
@cmcmarrow @waynew could you please restart the two failed tests? the errors seem unrelated to the PR |
Got confused between pool_delete and pool_undefine. Delete only deletes the data and is not implemented for remote volume pools like iSCSI or RBD... the secret needs to be removed when removing the libvirt definition of the pool instead.
cbosdo
force-pushed
the
virt-pool-build-fix
branch
from
7359e8f to
26979c7
Compare
Contributor
Author
|
rebased on latest master |
Contributor
Author
|
all green 💚 |
Some libvirt storage pools backends don't implement the build function. In thoses cases the virt.pool_defined and virt.pool_running states must not run the virt.pool_build() function. There are also cases where build only works once. For example when creating a LVM VG or a disk partition pool, if the VG or partition is already present build will fail. Fixes issue saltstack#56454
When updating a storage pool needing a secret don't fail if the secret is missing in libvirt: user may have mistakenly killed it. Instead create a new secret and log and information in the log.
cbosdo
force-pushed
the
virt-pool-build-fix
branch
from
26979c7 to
b1a9133
Compare
dwoz
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes several tiny problems related to virt storage pool functions:
virt.pool_definedandvirt.pool_updateif a pool build fails. Also don't build a pool if the pool type knowingly doesn't support that functionvirt.updateto avoid failurevirt.pool_delete()but invirt.pool_undefine()What issues does this PR fix or reference?
Fixes: issue #56454
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes