Virt cdrom fix #57479
Merged
Virt cdrom fix #57479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
twangboy
previously approved these changes
May 27, 2020
waynew
previously approved these changes
May 27, 2020
|
Pretty sure this will get merged after the code thaw 🧊 🌞 |
you mean it's likely not to hit Sodium? |
Akm0d
previously approved these changes
May 27, 2020
|
Rebased on master, added more tests and fixed an uncovered bug in the target name generation code |
|
rebased on master |
sagetherage
added
Bug
|
Updated on latest master |
salt/modules/virt.py
Outdated
| "{0}{1}".format(prefix, string.ascii_lowercase[i]) | ||
| for i in range(disks_count) | ||
| if "{0}{1}".format(prefix, string.ascii_lowercase[i]) not in targets | ||
| ][0] |
There was a problem hiding this comment.
Looks good but logically it should be more effective if we'll not build the entire list to just get the first item. Maybe something like this?
for i in range(disks_count):
ret = "{0}{1}".format(prefix, string.ascii_lowercase[i])
if ret not in targets:
return ret
There was a problem hiding this comment.
right, I'll change that then
|
@DmitryKuzmenko Just included your suggestion |
DmitryKuzmenko
previously approved these changes
Jul 24, 2020
Akm0d
previously approved these changes
Jul 29, 2020
cdrom sources can't be of format qcow2. Force raw as the default if needed when creating VM with source_file set for the cdrom.
Fixes issue saltstack#57477.
When a DVD device on a VM has a remote source, virt.update needs to be able to handle detaching it and attaching a file image live.
|
rebased on master |
Akm0d
approved these changes
Jul 31, 2020
s0undt3ch
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This issue fixes some issues with the handling of CDROM images attaching and changing on VM created or updated by
virt.init()andvirt.update()functions.What issues does this PR fix or reference?
Fixes: #57477
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes