Module rh_ip support ethtool set channels

[msciciel]

What does this PR do?

Introduce ability to control network interface channels using rh_ip module and network.managed state.

What issues does this PR fix or reference?

Fixes: #59147

Previous Behavior

It was not possible to control network interface channels. Salt ethtool module do not support channels too because it use python ethtool module which lacks support for channels.

New Behavior

Allow to control network interface channels. On some systems it is useful to manually control channel in order to achieve proper performance.

Merge requirements satisfied?

It's hard to write test for this because all other ethtool related options in rh_ip module do not have tests.

Commits signed with GPG?

No

[msciciel]

@cmcmarrow may I ask for some hint? I've changed my code to disappear from diff in Pre-Commit / Run Pre-Commit Against Salt (pull_request) test but it still fails and I have no clue why.

[sagetherage]

@cmcmarrow may I ask for some hint? I've changed my code to disappear from diff in Pre-Commit / Run Pre-Commit Against Salt (pull_request) test but it still fails and I have no clue why.

I apologize I missed this - I will get someone to help you with the dreaded pre-commit. @s0undt3ch @waynew can one of you help with pre-commit failures, here?

[ScriptAutomate]

@msciciel For setting up pre-commit, check the following guidance:

• https://docs.saltproject.io/en/master/topics/development/contributing.html#pre-commit-and-nox-setup

In the above link, depending on how your dev environment is setup, you'll see how you need to install pre-commit via pip, and then run pre-commit install in the root of the salt repo fork that you have locally.

Once you've followed those directions, you need to run the following to apply any fixes or guidance against the two files you are modifying:

pre-commit run --files salt/modules/rh_ip.py salt/states/network.py

After this command runs and applies changes, now create a new git commit that is taking all of the newly applied changes.

In the future, pre-commit will handle changes automatically without you having to run this command because it will run before any git commit is able to complete. :)

If you run into any more problems around pre-commit, feel free to ask. Additional assistance can be found on our Slack channel, if needed, also:

• https://saltstackcommunity.herokuapp.com/

[msciciel]

All checks have passed. Please review my contribution and i'm waiting for feedback.

[dmurphy18]

@msciciel Might have missed it, but wondering how the changes for channels are displayed or output, that is, is there any function doing the equivalent of '-l --show-channels', or is there a need ?

[msciciel]

@msciciel Might have missed it, but wondering how the changes for channels are displayed or output, that is, is there any function doing the equivalent of '-l --show-channels', or is there a need ?

Example state output looks like:

----------
          ID: eth0
    Function: network.managed
      Result: True
     Comment: Interface eth0 updated.
     Started: 14:36:08.176177
    Duration: 1830.047 ms
     Changes:
              ----------
              interface:
                  ---
                  +++
                  @@ -3,4 +3,5 @@
                   USERCTL="no"
                   TYPE="Ethernet"
                   ONBOOT="yes"
                  +ETHTOOL_OPTS="-L eth0  rx 4 tx 4 combined 4"
                   NM_CONTROLLED="no"
              status:
                  Interface eth0 restart to validate

Summary for local
------------
Succeeded: 1 (changed=1)
Failed:    0
------------
Total states run:     1
Total run time:   1.830 s

Example pillar:

# cat /srv/salt/ethtools.sls
eth0:
  network.managed:
  - enabled: True
  - type: eth
  - channels:
      rx: 4
      tx: 4
      combined: 4

To verify that interface is brought up with proper number of channels it is required to use ethtool -l eth0. Unfortunately salt module ethtool lacks such functionality because it is based on python-ethool module which also lacks such feature.

Altering channels number and ring size during interface initialization is safier than on busy system. I've experienced many cases where alteration of these parameter on busy system caused even kernel panic on some specific network card.

@dmurphy18 do I properly addressed your question or You have mean something else?

[dmurphy18]

Thanks for the response, looks good

[Ch3LL]

This will need test coverage added

[msciciel]

@Ch3LL Please verify if provided test is enough.

[Ch3LL]

Apologies I did not notice this on first review, but this will require a changelog entry. I can add it if you are not able to.

[msciciel]

Apologies I did not notice this on first review, but this will require a changelog entry. I can add it if you are not able to.

Thanks. Next time I will try to add changelog entry.