lvm.lv present accept mb, gb, tb, pb as size - Fix issue 58985 - #59610
Merged
Ch3LL merged 5 commits intoMar 3, 2021
Merged
Conversation
added 2 commits
February 24, 2021 22:00
- Updated the _convert_to_mb to handle units ending in "B", like "MB" or "GB" - Made a more resilient error handling for invalid size formats - Clarified in documentation what is expected by the "size" parameter - Updated the tests with the new use cases
Author
|
@sagetherage Hi, this fixes ##58985 which is marked for Aluminum, can it be merged for this release cycle instead to wait for the point release? |
garethgreenaway
approved these changes
Mar 2, 2021
Contributor
working on it |
Ch3LL
approved these changes
Mar 3, 2021
s0undt3ch
approved these changes
Mar 3, 2021
piterpunk
deleted the
lvm.lv_present-accept-MB_GB_TB_PB-as-size_Fix-Issue-58985
branch
March 8, 2021 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #58985
Previous Behavior
lvm.lv_presentfails ungracefully when an unknown size unit is used. Regression when using previously accepted MB, GB, TB, etc. Documentation is not clear about what are the accepted units.New Behavior
Now
lvm.lv_presentdocumentation presents the allowed units and makes clear that the default unit is in megabytes. Reverted the regression with MB, GB, TB, etc and internally converts then to M, G and T. Made a better error handling in unit convertion raising a more clear message when needed.Merge requirements satisfied?
Commits signed with GPG?
No