Improvements on "ansiblegate" module

[meaksh]

What does this PR do?

This PR adds some improvements to the "Ansiblegate" module of Salt:

• Move Ansible inventory collector from "AnsibleRoster" to Salt utils to reuse it
• Add ansible.targets method to gather Ansible inventory
• Add ansible.discover_playbooks method to help collecting playbooks.
• Fix crash when running Ansible playbooks if ansible-playbook CLI output is not the expected JSON.
• Fix issues when processing inventory and there are groups with no members.
• Allow new types of targets for Ansible roster

Merge requirements satisfied?

• Docs
• Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[meaksh]

@twangboy @Ch3LL any chance of reviewing this one? Thanks!

[meaksh]

@s0undt3ch maybe you can take a look at this one? Thanks in advance!

BTW, just wondering what is the propose of using [:] to get a copy of the declarated list at
https://github.com/saltstack/salt/pull/60056/files#diff-519146c38c0ed7bc961ffc5f408d3dd380abb8760d48e839743dbd38dc28ba15L47

[s0undt3ch]

@s0undt3ch maybe you can take a look at this one? Thanks in advance!

BTW, just wondering what is the propose of using [:] to get a copy of the declarated list at https://github.com/saltstack/salt/pull/60056/files#diff-519146c38c0ed7bc961ffc5f408d3dd380abb8760d48e839743dbd38dc28ba15L47

It's a failed implementation at separate copies of the same original list....

>>> a = b = [1, 2, 3]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 3]
>>> a = b = [1, 2, 3][:]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 3]
>>> a = b[:] = [1, 2, 3][:]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 2, 3]

ie, a bug.

😭

[s0undt3ch]

The correct code should

@s0undt3ch maybe you can take a look at this one? Thanks in advance!
BTW, just wondering what is the propose of using [:] to get a copy of the declarated list at https://github.com/saltstack/salt/pull/60056/files#diff-519146c38c0ed7bc961ffc5f408d3dd380abb8760d48e839743dbd38dc28ba15L47

It's a failed implementation at separate copies of the same original list....

>>> a = b = [1, 2, 3]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 3]
>>> a = b = [1, 2, 3][:]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 3]
>>> a = b[:] = [1, 2, 3][:]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 2, 3]

ie, a bug.

sob

The correct code should be:

>>> a = b[:] = [1, 2, 3]
>>> a
[1, 2, 3]
>>> b
[1, 2, 3]
>>> a.remove(2)
>>> a
[1, 3]
>>> b
[1, 2, 3]
>>>

[s0undt3ch]

Here's an initial review

[meaksh]

@s0undt3ch thanks for the review! 👍

I've pushed the changes you suggested on the review

[garethgreenaway]

@meaksh Looks like this one has some merge conflicts.

[meaksh]

Thanks for the review @garethgreenaway !

I've have rebased with latest master so conflicts are now solved.

[Ch3LL]

there is a merge conflict that needs to be resolved.

[meaksh]

@Ch3LL conflicts are now fixed 👍

[meaksh]

@Ch3LL thanks again for the review. I've addressed your comments and I think this is now ready.

I hope it can gets into 3005!

[Ch3LL]

Unfortunately I was not able to get this into 3005 since we were on a tight timeline. I'll go ahead and update the versionadded versions to 3006 and help get this merged in. I'll also label it 3006 so it for sure makes it into that release.

[Ch3LL]

So we actually ended up rebasing master with the release, so this will actually end up in 3005 ! yay! I also updated the versionadded to 3005: #62331