Salt's ansiblegate module fixes #60208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
6 times, most recently
from
0cf72cd
to
a65d1e3
Compare
krionbsd
previously approved these changes
May 19, 2021
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
2 times, most recently
from
f0e4970
to
397f385
Compare
s0undt3ch
changed the title
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
2 times, most recently
from
488bbcb
to
b365bfa
Compare
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
2 times, most recently
from
a862817
to
afc1126
Compare
Ch3LL
previously approved these changes
Jun 1, 2021
sagetherage
added
the
ZD
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
from
afc1126
to
ad490db
Compare
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
from
ad490db
to
5c0a2a6
Compare
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
3 times, most recently
from
12feb92
to
cca5940
Compare
Ch3LL
reviewed
Jun 29, 2021
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
from
cca5940
to
00e9c60
Compare
Ch3LL
previously approved these changes
Jun 29, 2021
waynew
suggested changes
Jun 29, 2021
They cannot be called by passing their path, for example:
```
Traceback (most recent call last):
File ".nox/pytest-parametrized-3-7-crypto-none-transport-zeromq-coverage-false/lib/python3.7/site-packages/ansible/modules/ping.py", line 63, in <module>
from ansible.module_utils.basic import AnsibleModule
File "/home/vampas/projects/SaltStack/salt/hotfix/ansiblegate-59792/.nox/pytest-parametrized-3-7-crypto-none-transport-zeromq-coverage-false/lib/python3.7/site-packages/ansible/module_utils/basic.py", line 53, in <module>
import tempfile
File "/home/vampas/projects/SaltStack/salt/hotfix/ansiblegate-59792/.nox/pytest-parametrized-3-7-crypto-none-transport-zeromq-coverage-false/lib/python3.7/site-packages/ansible/modules/tempfile.py", line 79, in <module>
from tempfile import mkstemp, mkdtemp
ImportError: cannot import name 'mkstemp' from 'tempfile' (/home/vampas/projects/SaltStack/salt/hotfix/ansiblegate-59792/.nox/pytest-parametrized-3-7-crypto-none-transport-zeromq-coverage-false/lib/python3.7/site-packages/ansible/modules/tempfile.py)
```
For example, running locally, under non-root account, ansible complains about missing sudo password.
…Ansible module calls Fixes saltstack#59792
… not just internal.
s0undt3ch
force-pushed
the
hotfix/ansiblegate-60207
branch
from
00e9c60
to
36fcc6d
Compare
Ch3LL
approved these changes
Jun 30, 2021
krionbsd
approved these changes
Jun 30, 2021
garethgreenaway
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This was broken in 3001(9243888#diff-519146c38c0ed7bc961ffc5f408d3dd380abb8760d48e839743dbd38dc28ba15R323).
What issues does this PR fix or reference?
Fixes #60207
Fixes #59792
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes