Fix race condition in batch logic #56273 #60256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dwoz
force-pushed
the
issue/master/56273
branch
2 times, most recently
from
77ee859
to
62b4f53
Compare
dwoz
changed the title
sagetherage
added
Aluminium
cmcmarrow
previously approved these changes
May 27, 2021
garethgreenaway
previously approved these changes
May 27, 2021
s0undt3ch
reviewed
May 28, 2021
s0undt3ch
requested changes
Jun 4, 2021
Merged
garethgreenaway
previously approved these changes
Jun 4, 2021
waynew
reviewed
Jun 4, 2021
|
re-run all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix race condition in batch logic by letting the event subscriber to keep listening between batch iterations.
What issues does this PR fix or reference?
Fixes: #56273
Previous Behavior
After batches LocalClient would close the event subscriber purging events that could potentially be needed other batches.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.