Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow module_refresh to also refresh available beacons #60542

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Jul 14, 2021

What does this PR do?

Allow module_refresh to also refresh available beacons, eg. following a Python library being installed and "refresh_modules" being passed as an argument in a state.

What issues does this PR fix or reference?

Fixes: #60541

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

… a Python library being installed and "refresh_modules" being passed as an argument in a state.
@garethgreenaway garethgreenaway requested a review from a team as a code owner July 14, 2021 01:46
@garethgreenaway garethgreenaway requested review from xeacott and UtahDave and removed request for a team July 14, 2021 01:46
UtahDave
UtahDave previously approved these changes Jul 14, 2021
Copy link
Contributor

@UtahDave UtahDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a manual test with this PR and it worked great. I was able to apply a state that installs the inotify beacon and then set up the inotify beacon to watch a file and reload the beacon and have the beacon start working immediately.

Thanks!!

@garethgreenaway
Copy link
Contributor Author

re-run all

@garethgreenaway garethgreenaway added the Silicon v3004.0 Release code name label Jul 27, 2021
Ch3LL
Ch3LL previously approved these changes Jul 27, 2021
UtahDave
UtahDave previously approved these changes Jul 27, 2021
Copy link
Contributor

@UtahDave UtahDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@garethgreenaway
Copy link
Contributor Author

re-run all

@Ch3LL Ch3LL merged commit 8cea4e9 into saltstack:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Silicon v3004.0 Release code name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Allow reload_modules to reload beacons
3 participants