Add detect_remote_minions and remote_minions_port options to detect minions connected on other ports #60633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows presence events to work with Heist-Salt minions. I'm definitely up for suggestions on what we should call these two different options. I was not certain what I picked was the best name to choose.
What issues does this PR fix or reference?
Fixes: #60612
Previous Behavior
Presence events would not work with heist-salt minions which the salt master connects to the minions over port 22.
New Behavior
If a user sets the configurations
detect_remote_minionsto True it will try to detect connected minions over port 22 unless the port specified is changed with the configurationremote_minions_portMerge requirements satisfied?
Commits signed with GPG?
Yes