Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting service state changes, return changes in pkg state #61018

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Oct 8, 2021

What does this PR do?

Reverting changes in PR #60150. Updating installed and removed functions to return changes when test=True.

What issues does this PR fix or reference?

Fixes: #60995

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…ed functions to return changes when test=True.
@garethgreenaway garethgreenaway requested a review from a team as a code owner October 8, 2021 22:26
@garethgreenaway garethgreenaway requested review from twangboy and removed request for a team October 8, 2021 22:26
@garethgreenaway garethgreenaway added the Silicon v3004.0 Release code name label Oct 8, 2021
@garethgreenaway garethgreenaway changed the base branch from master to freeze October 8, 2021 22:32
@garethgreenaway garethgreenaway changed the base branch from freeze to master October 8, 2021 22:32
@garethgreenaway garethgreenaway deleted the pkg_state_return_changes_test_true branch October 8, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Silicon v3004.0 Release code name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 3004rc1: Service states incorrectly report they will restart in test mode
1 participant