Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sphinx 4.2 #61047

Merged
merged 1 commit into from Feb 10, 2022
Merged

Support sphinx 4.2 #61047

merged 1 commit into from Feb 10, 2022

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Oct 13, 2021

Add the sphinx documentation options provided by sphinx 4.2. Otherwise the search will produce URLs with undefined instead of .html:

ref/states/all/salt.states.fileundefined?highlight=file#module-salt.states.file

@bdrung bdrung requested a review from a team as a code owner October 13, 2021 18:31
@bdrung bdrung requested review from waynew and removed request for a team October 13, 2021 18:31
bdrung added a commit to bdrung/salt that referenced this pull request Oct 13, 2021
Add the sphinx documentation options provided by sphinx 4.2. Otherwise
the search will produce URLs with `undefined` instead of `.html`:

```
ref/states/all/salt.states.fileundefined?highlight=file#module-salt.states.file
```

Forwarded: saltstack#61047
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
bdrung added a commit to bdrung/salt that referenced this pull request Oct 14, 2021
Add the sphinx documentation options provided by sphinx 4.2. Otherwise
the search will produce URLs with `undefined` instead of `.html`:

```
ref/states/all/salt.states.fileundefined?highlight=file#module-salt.states.file
```

Forwarded: saltstack#61047
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
@bdrung
Copy link
Contributor Author

bdrung commented Dec 11, 2021

Rebased on master.

waynew
waynew previously approved these changes Dec 15, 2021
Ch3LL
Ch3LL previously approved these changes Dec 15, 2021
Add the sphinx documentation options provided by sphinx 4.2. Otherwise
the search will produce URLs with `undefined` instead of `.html`:

```
ref/states/all/salt.states.fileundefined?highlight=file#module-salt.states.file
```

Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
@waynew
Copy link
Contributor

waynew commented Feb 4, 2022

Let's see if the tests all pass this time 😂

@bdrung
Copy link
Contributor Author

bdrung commented Feb 7, 2022

No, some unrelated functional tests still fail.

@Ch3LL Ch3LL merged commit 1f66021 into saltstack:master Feb 10, 2022
@bdrung bdrung deleted the support-sphinx-4.2 branch February 10, 2022 21:02
bdrung added a commit to bdrung/salt that referenced this pull request Apr 15, 2022
Add the sphinx documentation options provided by sphinx 4.2. Otherwise
the search will produce URLs with `undefined` instead of `.html`:

```
ref/states/all/salt.states.fileundefined?highlight=file#module-salt.states.file
```

Forwarded: saltstack#61047
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
bdrung added a commit to bdrung/salt that referenced this pull request Apr 15, 2022
Add the sphinx documentation options provided by sphinx 4.2. Otherwise
the search will produce URLs with `undefined` instead of `.html`:

```
ref/states/all/salt.states.fileundefined?highlight=file#module-salt.states.file
```

Forwarded: saltstack#61047
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants