Fix file.replace mtime update on no changes #61744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-run pr-debian-9-amd64-py3-pytest |
|
re-run pr-arch-lts-x86_64-py3-pytest |
waynew
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Good find! I went back to double check, and it looks like that was an inadvertent change, and lacking test coverage it wasn't caught 🙃
Just to be on the safe side I pulled this down and banged on it a bit. I couldn't make things break without actually breaking things. This looks like a good fix - it could be spelled differently but I think that's just a matter of taste.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reintroduces the fix from #56359 which was reverted (inadvertently?) in #56621
What issues does this PR fix or reference?
Fixes: #61743
Previous Behavior
File mtime always updated when the pattern doesn't match the replacement value.
New Behavior
File mtime only updated when the content changes.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.