New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Salt to work with Jinja >= and <= 3.1.0 #61856
Conversation
re-run all |
I've used this patch when building the |
Perhaps this will also close #60745 -- I haven't tested that. |
re-run all |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.05s - exit code: 1 Thanks again! |
The fix for this has only just been merged into the `master` branch: * saltstack/salt#61856
The fix for this has only just been merged into the `master` branch: * saltstack/salt#61856
Great! Is this going to be backported on older salt versions? |
What does this PR do?
Updates Markup and contextfunction to work with all versions of Jinja2. Markup was moved to markupsafe and contextfunction was changed to pass_context in Jinja 3.1
What issues does this PR fix or reference?
Fixes: #61848 #60745