Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nftables.delete not working when no position arg provided #61975

Closed
wants to merge 1 commit into from

Conversation

mlalpho
Copy link
Contributor

@mlalpho mlalpho commented Apr 21, 2022

when position not provided, the data structure of position changes when sent out to cmd.run

What does this PR do?

What issues does this PR fix or reference?

Fixes:
Error when calling nftables.delete with full rule (no position)

 [ERROR   ] stdout: Error: syntax error, unexpected '{', expecting number
                  delete rule ip filter INPUT handle {result: True, handle: 45}

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Thoughts? @garethgreenaway :)

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@mlalpho mlalpho requested a review from a team as a code owner April 21, 2022 22:16
@mlalpho mlalpho requested review from dwoz and removed request for a team April 21, 2022 22:16
@mlalpho mlalpho changed the title when position not provided, the data structure of position changes wh… fix nftables.delete not working when no position arg provided Apr 21, 2022
@dwoz
Copy link
Contributor

dwoz commented Dec 11, 2023

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

@dwoz dwoz closed this Dec 11, 2023
@mlalpho
Copy link
Contributor Author

mlalpho commented Dec 11, 2023

@dwoz What else needs to be done? Tests? 🤔 Anyone else using nftables to confirm the bug? I've run into a few issues with nftables modules/states.

I'm not in a good position write tests, at the moment. I'd appreciate some help otherwise I'll be able to revisit some time later 🤷‍♂️

Thank you!

@dwoz
Copy link
Contributor

dwoz commented Dec 16, 2023

@mlalpho We'd need it to be re-opened against master with tests and a changlog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants