Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed backslash literal bytestring for file.replace #62069

Merged

Conversation

emmadionne1
Copy link
Contributor

What does this PR do?

see issue for details

What issues does this PR fix or reference?

Fixes: #61944

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@emmadionne1 emmadionne1 requested a review from a team as a code owner May 16, 2022 16:03
@emmadionne1 emmadionne1 requested review from Ch3LL and removed request for a team May 16, 2022 16:03
@welcome
Copy link

welcome bot commented May 16, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@nicholasmhughes
Copy link
Collaborator

re-run full all

@nicholasmhughes nicholasmhughes self-requested a review May 17, 2022 00:21
@nicholasmhughes
Copy link
Collaborator

re-run pr-alma-8-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-centosstream-8-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-freebsd-130-amd64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-arch-lts-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-fedora-35-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-centos-7-x86_64-py3-pycryptodome-pytest

1 similar comment
@nicholasmhughes
Copy link
Collaborator

re-run pr-centos-7-x86_64-py3-pycryptodome-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-amazon-2-x86_64-py3-pytest

@nicholasmhughes nicholasmhughes added the Phosphorus v3005.0 Release code name and version label May 18, 2022
@Ch3LL Ch3LL merged commit 5e03515 into saltstack:master May 19, 2022
@welcome
Copy link

welcome bot commented May 19, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] file.replace backslash_literal=True causing bytes issues
3 participants