Repository navigation
add support for gpgautoimport to refresh_db in the zypperpkg module - #62209
Merged
Merged
Conversation
mcalmer
force-pushed
the
options-for-zypper-refresh
branch
from
June 23, 2022 08:51
89f4c5c to
3eb2e76
Compare
vzhestkov
suggested changes
Jun 23, 2022
vzhestkov
left a comment
vzhestkov
left a comment
Contributor
There was a problem hiding this comment.
I've put some comments in the code
vzhestkov
reviewed
Jun 23, 2022
mcalmer
force-pushed
the
options-for-zypper-refresh
branch
2 times, most recently
from
June 24, 2022 08:11
77cb658 to
53aed44
Compare
vzhestkov
previously approved these changes
Jun 24, 2022
vzhestkov
left a comment
vzhestkov
left a comment
Contributor
There was a problem hiding this comment.
Looks good 👍 thanks for addressing the suggestions
Contributor
|
@mcalmer there is a test failing |
mcalmer
force-pushed
the
options-for-zypper-refresh
branch
from
June 24, 2022 10:07
485c287 to
5b0aeaf
Compare
Contributor
Author
|
@vzhestkov should be fixed now |
meaksh
previously approved these changes
Jul 6, 2022
mcalmer
force-pushed
the
options-for-zypper-refresh
branch
from
July 10, 2022 14:10
042f8bb to
61e2b59
Compare
meaksh
reviewed
Jul 11, 2022
mcalmer
force-pushed
the
options-for-zypper-refresh
branch
from
July 11, 2022 09:03
8b7f7d3 to
3ff93f3
Compare
meaksh
previously approved these changes
Jul 11, 2022
mcalmer
force-pushed
the
options-for-zypper-refresh
branch
from
January 11, 2023 10:37
560bf91 to
c9a97e4
Compare
meaksh
previously approved these changes
Jan 11, 2023
meaksh
left a comment
meaksh
left a comment
Contributor
There was a problem hiding this comment.
Just added some small comment about the "versionadded", other than that LGTM.
meaksh
approved these changes
Jan 11, 2023
Contributor
Author
|
@waynew I clicked somehow at the wrong place and removed you from reviewers list. This is now a long time open and I think it should be merged now. Please have a look again. Thanks |
Co-authored-by: Pablo Suárez Hernández <psuarezhernandez@suse.com>
Co-authored-by: Pablo Suárez Hernández <psuarezhernandez@suse.com>
dwoz
force-pushed
the
options-for-zypper-refresh
branch
from
December 10, 2023 23:44
b1cf5c0 to
b793657
Compare
dwoz
approved these changes
Dec 16, 2023
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
* add support for gpgautoimport to refresh_db in the zypperpkg module * call refresh_db function from mod_repo * call refresh_db with kwargs where possible * ignore no repos defined exit code * fix zypperpkg test after adding more success return codes BACKPORT-UPSTREAM=saltstack#62209
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #42039
Previous Behavior
When using the zypper pkg module a refresh could never import GPG keys.
New Behavior
Now an option is available to enable autoimport of GPG keys. The default is still
offMerge requirements satisfied?
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.