Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove impacket #62840

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Remove impacket #62840

merged 2 commits into from
Oct 10, 2022

Conversation

xeacott
Copy link
Contributor

@xeacott xeacott commented Oct 7, 2022

What does this PR do?

Remove left over usage of impacket. This dependency is causing issues with the salt-master during init stage if this package is installed on py3.9 for Rhel.

What issues does this PR fix or reference?

Fixes: #62101

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@xeacott xeacott requested a review from a team as a code owner October 7, 2022 17:08
@xeacott xeacott requested review from whytewolf and removed request for a team October 7, 2022 17:08
@xeacott
Copy link
Contributor Author

xeacott commented Oct 7, 2022

Have since checked all usage of impacket and this should be okay to the best of my understanding. Although that exception being raised, from smbprotocol.exceptions import InternalError as smbSessionError may not be as indicative of a session issue, the call itself goes into util/smb.py where it's further handled -> __salt__["smb.get_conn"] and more correctly for that matter.

@Ch3LL Ch3LL merged commit a1d76dc into saltstack:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] saltify driver still expects Impacket
4 participants