Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipset state when the comment kwarg is set. #63065

Merged
merged 2 commits into from Nov 18, 2022
Merged

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Nov 15, 2022

What does this PR do?

Fixes ipset.present when using comments as a kwarg.

What issues does this PR fix or reference?

Fixes: #61122

Previous Behavior

          ID: setname_entries
    Function: ipset.present
      Result: False
     Comment: Failed to add to entry 192.168.0.3 comment "Hello19" to set setname3 for family ipv4.
              Error: ipset v7.15: Syntax error: cannot parse 192.168.0.3 comment "Hello19": resolving to IPv4 address failed
     Started: 09:05:15.671586
    Duration: 20.856 ms
     Changes:   

New Behavior

          ID: setname_entries
    Function: ipset.present
      Result: True
     Comment: entry 192.168.0.3 comment Hello19 added to set setname3 for family ipv4
     Started: 09:05:33.698257
    Duration: 20.674 ms
     Changes:   
              ----------
              locale:
                  setname_entries

@Ch3LL Ch3LL requested a review from a team as a code owner November 15, 2022 16:07
@Ch3LL Ch3LL requested review from garethgreenaway and removed request for a team November 15, 2022 16:07
@Ch3LL Ch3LL added the Sulfur v3006.0 release code name and version label Nov 15, 2022
@MKLeb
Copy link
Contributor

MKLeb commented Nov 17, 2022

looks good to me, just re-ran some flaky test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipset with comment is broken in 3004
3 participants