Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'src' to state network.routes #63385

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CrackerJackMack
Copy link

What does this PR do?

Adds the ability to add src (via source name) to IP routes via the state network.routes

What issues does this PR fix or reference?

Fixes: #63384

New Behavior

Adding source to a route definition applies src to the correct configurations on modern operating systems.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@CrackerJackMack CrackerJackMack requested a review from a team as a code owner December 27, 2022 15:06
@CrackerJackMack CrackerJackMack requested review from dwoz and removed request for a team December 27, 2022 15:06
@welcome
Copy link

welcome bot commented Dec 27, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@dwoz
Copy link
Contributor

dwoz commented Dec 12, 2023

@CrackerJackMack Are you able to come up with a test for this?

@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Dec 12, 2023
@dwoz dwoz added this to the Argon v3008.0 milestone Dec 12, 2023
@CrackerJackMack
Copy link
Author

Not that i recall. Been a hot minute since I had to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Support 'src' in network.routes state
2 participants