Skip to content

Add junit saltcheck - #63464

Merged
Ch3LL merged 12 commits into
saltstack:masterfrom
M3GH4NN:add-junit-saltcheck
Jun 9, 2023
Merged

Add junit saltcheck#63464
Ch3LL merged 12 commits into
saltstack:masterfrom
M3GH4NN:add-junit-saltcheck

Conversation

@M3GH4NN

@M3GH4NN M3GH4NN commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

adds JUnit output to saltcheck

What issues does this PR fix or reference?

Fixes: #63463

Previous Behavior

Could not output JUnit

New Behavior

Now you can output JUnit with saltcheck

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@M3GH4NN
M3GH4NN requested a review from a team as a code owner January 11, 2023 19:07
@M3GH4NN
M3GH4NN requested review from whytewolf and removed request for a team January 11, 2023 19:07
@welcome

welcome Bot commented Jan 11, 2023

Copy link
Copy Markdown

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

twangboy
twangboy requested changes Jan 11, 2023
View reviewed changes
Comment thread requirements/static/ci/common.in Outdated
s0undt3ch
s0undt3ch suggested changes Jan 15, 2023
View reviewed changes
Comment thread salt/modules/saltcheck.py Outdated
Comment thread requirements/static/ci/common.in Outdated
s0undt3ch
s0undt3ch previously approved these changes Jan 17, 2023
View reviewed changes
@s0undt3ch

s0undt3ch commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Test failure looks related.

s0undt3ch
s0undt3ch suggested changes Jan 19, 2023
View reviewed changes
Comment thread tests/pytests/unit/modules/test_saltcheck.py Outdated
Comment thread tests/pytests/unit/modules/test_saltcheck.py Outdated
s0undt3ch
s0undt3ch previously approved these changes Jan 19, 2023
View reviewed changes
@whytewolf

whytewolf commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

looks like precommit failed. for black and pylint.

@nicholasmhughes nicholasmhughes added AIX affects this operating system Chlorine v3007.0 and removed AIX affects this operating system labels Jan 26, 2023
nicholasmhughes
nicholasmhughes suggested changes Jan 30, 2023
View reviewed changes
Comment thread salt/modules/saltcheck.py Outdated
@nicholasmhughes

nicholasmhughes commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

re-run pr-arch-lts-x86_64-py3-pytest

@nicholasmhughes

nicholasmhughes commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

re-run pr-centos-7-x86_64-py3-pytest

nicholasmhughes
nicholasmhughes previously approved these changes Feb 1, 2023
View reviewed changes
@nicholasmhughes

nicholasmhughes commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

re-run pr-photon-3-x86_64-py3-pytest

1 similar comment
@nicholasmhughes

nicholasmhughes commented Feb 4, 2023

Copy link
Copy Markdown
Contributor

re-run pr-photon-3-x86_64-py3-pytest

@nicholasmhughes

nicholasmhughes commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

re-run pr-centos-7-x86_64-py3-pytest

@nicholasmhughes

nicholasmhughes commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

re-run pr-photon-3-x86_64-py3-pytest

@nicholasmhughes

nicholasmhughes commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

re-run pr-arch-lts-x86_64-py3-pytest

@Ch3LL
Ch3LL temporarily deployed to ci June 7, 2023 21:44 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci June 7, 2023 21:44 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci June 7, 2023 22:23 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci June 7, 2023 22:39 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci June 7, 2023 22:45 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch force-pushed the add-junit-saltcheck branch from 404220b to c7e3a71 Compare June 9, 2023 14:55
@s0undt3ch
s0undt3ch temporarily deployed to ci June 9, 2023 15:47 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch temporarily deployed to ci June 9, 2023 15:48 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch temporarily deployed to ci June 9, 2023 15:48 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch temporarily deployed to ci June 9, 2023 15:48 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch temporarily deployed to ci June 9, 2023 16:08 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch temporarily deployed to ci June 9, 2023 16:10 — with GitHub Actions Inactive
@nicholasmhughes

nicholasmhughes commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

@Ch3LL , looks good!

@Ch3LL
Ch3LL merged commit 09569cd into saltstack:master Jun 9, 2023
@welcome

welcome Bot commented Jun 9, 2023

Copy link
Copy Markdown

Congratulations on your first PR being merged! 🎉

@nicholasmhughes
nicholasmhughes deleted the add-junit-saltcheck branch January 27, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twangboy twangboy twangboy left review comments
+4 more reviewers
@nicholasmhughes nicholasmhughes nicholasmhughes approved these changes
@Ch3LL Ch3LL Ch3LL approved these changes
@s0undt3ch s0undt3ch s0undt3ch left review comments
@whytewolf whytewolf whytewolf left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Chlorine v3007.0 merge-conflict PR has a merge conflict

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] JUnit output for saltcheck

6 participants

@M3GH4NN @s0undt3ch @whytewolf @nicholasmhughes @Ch3LL @twangboy