Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add junit saltcheck #63464

Merged
merged 12 commits into from Jun 9, 2023
Merged

Add junit saltcheck #63464

merged 12 commits into from Jun 9, 2023

Conversation

M3GH4NN
Copy link
Contributor

@M3GH4NN M3GH4NN commented Jan 11, 2023

What does this PR do?

adds JUnit output to saltcheck

What issues does this PR fix or reference?

Fixes: #63463

Previous Behavior

Could not output JUnit

New Behavior

Now you can output JUnit with saltcheck

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@M3GH4NN M3GH4NN requested a review from a team as a code owner January 11, 2023 19:07
@M3GH4NN M3GH4NN requested review from whytewolf and removed request for a team January 11, 2023 19:07
@welcome
Copy link

welcome bot commented Jan 11, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

twangboy
twangboy requested changes Jan 11, 2023
View reviewed changes
requirements/static/ci/common.in Outdated Show resolved Hide resolved
s0undt3ch
s0undt3ch requested changes Jan 15, 2023
View reviewed changes
salt/modules/saltcheck.py Outdated Show resolved Hide resolved
requirements/static/ci/common.in Outdated Show resolved Hide resolved
s0undt3ch
s0undt3ch previously approved these changes Jan 17, 2023
View reviewed changes
@s0undt3ch
Copy link
Member

Test failure looks related.

s0undt3ch
s0undt3ch requested changes Jan 19, 2023
View reviewed changes
tests/pytests/unit/modules/test_saltcheck.py Outdated Show resolved Hide resolved
tests/pytests/unit/modules/test_saltcheck.py Outdated Show resolved Hide resolved
s0undt3ch
s0undt3ch previously approved these changes Jan 19, 2023
View reviewed changes
@whytewolf
Copy link
Contributor

looks like precommit failed. for black and pylint.

@nicholasmhughes nicholasmhughes added AIX affects this operating system Chlorine v3007.0 and removed AIX affects this operating system labels Jan 26, 2023
nicholasmhughes
nicholasmhughes suggested changes Jan 30, 2023
View reviewed changes
salt/modules/saltcheck.py Outdated Show resolved Hide resolved
@nicholasmhughes
Copy link
Collaborator

re-run pr-arch-lts-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-centos-7-x86_64-py3-pytest

nicholasmhughes
nicholasmhughes previously approved these changes Feb 1, 2023
View reviewed changes
@nicholasmhughes
Copy link
Collaborator

re-run pr-photon-3-x86_64-py3-pytest

1 similar comment
@nicholasmhughes
Copy link
Collaborator

re-run pr-photon-3-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-centos-7-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-photon-3-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator

re-run pr-arch-lts-x86_64-py3-pytest

@Ch3LL Ch3LL temporarily deployed to ci June 7, 2023 21:44 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci June 7, 2023 21:44 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci June 7, 2023 22:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci June 7, 2023 22:39 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci June 7, 2023 22:45 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci June 9, 2023 15:47 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci June 9, 2023 15:48 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci June 9, 2023 15:48 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci June 9, 2023 15:48 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci June 9, 2023 16:08 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci June 9, 2023 16:10 — with GitHub Actions Inactive
@nicholasmhughes
Copy link
Collaborator

@Ch3LL , looks good!

@Ch3LL Ch3LL merged commit 09569cd into saltstack:master Jun 9, 2023
309 checks passed
@welcome
Copy link

welcome bot commented Jun 9, 2023

Congratulations on your first PR being merged! 🎉

@nicholasmhughes nicholasmhughes deleted the add-junit-saltcheck branch January 27, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasmhughes nicholasmhughes nicholasmhughes approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@s0undt3ch s0undt3ch s0undt3ch left review comments

@whytewolf whytewolf whytewolf left review comments

@twangboy twangboy twangboy left review comments

Assignees
No one assigned
Labels
Chlorine v3007.0 merge-conflict PR has a merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] JUnit output for saltcheck
6 participants
@M3GH4NN @s0undt3ch @whytewolf @nicholasmhughes @Ch3LL @twangboy