Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back ssm.exe to salt onedir tarball #63804

Merged
merged 1 commit into from Mar 9, 2023

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Mar 1, 2023

What does this PR do?

Adds back ssm.exe to the salt tarball for Windows. It is needed for vmtools

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@twangboy twangboy requested a review from a team as a code owner March 1, 2023 23:02
@twangboy twangboy requested review from cmcmarrow and removed request for a team March 1, 2023 23:02
MKLeb
MKLeb previously approved these changes Mar 1, 2023
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth it to write a test to ensure ssm.exe is in the onedir?

I believe this test could be added to the main test suite, since it uses the onedir builds to test against.

@s0undt3ch s0undt3ch merged commit 1d6379a into saltstack:master Mar 9, 2023
@twangboy twangboy deleted the add_back_ssm branch March 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants