Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging to win_pkg.remove #63867

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

dafyddj
Copy link
Contributor

@dafyddj dafyddj commented Mar 12, 2023

What does this PR do?

Adds a debug message to display the actual command that is being run when removing packages using the Windows package manager.

What issues does this PR fix or reference?

Fixes: #63866

Previous Behavior

Nothing relevant was logged

New Behavior

Displays a debug message similar this:

[DEBUG   ] PKG : cmd: C:\Windows\system32\cmd.exe /s /c "msiexec" /X "C:\ProgramData\Salt Project\Salt\var\cache\salt\mi
nion\extrn_files\base\the.earth.li\~sgtatham\putty\0.78\w64\putty-64bit-0.78-installer.msi" /qn
[DEBUG   ] PKG : pwd: C:\ProgramData\Salt Project\Salt\var\cache\salt\minion\extrn_files\base\the.earth.li\~sgtatham\put
ty\0.78\w64

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@dafyddj dafyddj force-pushed the feat/win_pkg-logging branch 2 times, most recently from f32af86 to 59c80e1 Compare March 13, 2023 21:26
@dafyddj dafyddj marked this pull request as ready for review March 13, 2023 21:27
@dafyddj dafyddj requested a review from a team as a code owner March 13, 2023 21:27
@dafyddj dafyddj requested review from whytewolf and removed request for a team March 13, 2023 21:27
@dafyddj dafyddj changed the title Feat/win pkg logging Add debug logging to win_pkg.remove Mar 14, 2023
@twangboy twangboy added the Sulfur v3006.0 release code name and version label Mar 14, 2023
@twangboy twangboy added this to the Sulfur v3006.0 milestone Mar 14, 2023
@Ch3LL Ch3LL merged commit c475db0 into saltstack:master Mar 15, 2023
@twangboy twangboy mentioned this pull request Mar 15, 2023
3 tasks
@dafyddj dafyddj deleted the feat/win_pkg-logging branch March 15, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] win_pkg.py add debug logging for pkg.remove
4 participants