New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow runas env retrieval to not block. #63912
base: master
Are you sure you want to change the base?
Allow runas env retrieval to not block. #63912
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
6fb5bae
to
895d10e
Compare
895d10e
to
51b03b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been running this patch in our environment on 3005, 3006, and now 3006.1 with success.
What does this PR do?
Add a timeout to subprocess call to retrieve runas user's environment.
IMO, this PR is incomplete for at least two reasons:
10
. Doessalt
have a preferred way to make this configurable?What issues does this PR fix or reference?
Fixes: 63901
Previous Behavior
On certain systems, the subprocess call to retrieve the runas user's environment would hang indefinitely. By applying a timeout, this process can at least continue.
New Behavior
Timeout allows the execution flow to continue.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes