Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Deprecate proxmox cloud #64453

Merged
merged 7 commits into from Aug 25, 2023
Merged

Conversation

I3urny
Copy link
Contributor

@I3urny I3urny commented Jun 12, 2023

What does this PR do?

Deprecate proxmox cloud

What issues does this PR fix or reference?

Fixes: #64224

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@I3urny I3urny requested a review from a team as a code owner June 12, 2023 11:02
@I3urny I3urny requested review from whytewolf and removed request for a team June 12, 2023 11:02
@welcome
Copy link

welcome bot commented Jun 12, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Deprecate proxmox cloud [master] Deprecate proxmox cloud Jun 12, 2023
@whytewolf
Copy link
Contributor

I know it seems silly since this is a deprecation. but the added utils decorator does need a test.

@I3urny I3urny temporarily deployed to ci June 12, 2023 16:36 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 16:36 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 16:36 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 16:37 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 16:57 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 17:02 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 18:09 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 18:09 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 18:09 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 18:09 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 18:10 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 18:10 — with GitHub Actions Inactive
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.saltproject.io/en/latest/topics/development/deprecations.html

The version should be 3009. "A deprecation warning should be in place for at least two major releases"

@I3urny I3urny requested a review from Ch3LL June 12, 2023 22:47
@I3urny I3urny temporarily deployed to ci June 12, 2023 23:07 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 23:07 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 23:07 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 23:24 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 12, 2023 23:27 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 13, 2023 00:13 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 13, 2023 00:13 — with GitHub Actions Inactive
@I3urny I3urny temporarily deployed to ci June 13, 2023 00:13 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 21:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 22:06 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 00:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 00:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 00:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 00:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 00:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 00:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 01:58 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 01:58 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 01:58 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 01:58 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 01:58 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 01:58 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:22 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:22 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 25, 2023 00:33 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 25, 2023 00:33 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 25, 2023 00:33 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 25, 2023 00:33 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 25, 2023 00:34 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 25, 2023 00:34 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 82d35f5 into saltstack:master Aug 25, 2023
325 checks passed
@I3urny I3urny deleted the deprecate-proxmox branch August 26, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Deprecate Proxmox Cloud Modules
4 participants