Skip to content

[master] implement jq-esque to_entries and from_entries functions - #64602

Merged
s0undt3ch merged 5 commits into
saltstack:masterfrom
nicholasmhughes:add-jq-entries-functions
Aug 14, 2023
Merged

[master] implement jq-esque to_entries and from_entries functions#64602
s0undt3ch merged 5 commits into
saltstack:masterfrom
nicholasmhughes:add-jq-entries-functions

Conversation

@nicholasmhughes

@nicholasmhughes nicholasmhughes commented Jul 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

see issue for details

What issues does this PR fix or reference?

Fixes: #64600

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes
nicholasmhughes requested a review from a team as a code owner July 5, 2023 15:30
@nicholasmhughes
nicholasmhughes requested review from MKLeb and removed request for a team July 5, 2023 15:30
@salt-project-bot-prod-environment salt-project-bot-prod-environment Bot changed the title implement jq-esque to_entries and from_entries functions [master] implement jq-esque to_entries and from_entries functions Jul 5, 2023
s0undt3ch
s0undt3ch previously approved these changes Jul 6, 2023
View reviewed changes
@s0undt3ch

s0undt3ch commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

The error preventing the CI run:

reading sources... [100%] topics/venafi/index .. topics/yaml/index                                                                                                                           
/home/runner/work/salt/salt/doc/topics/jinja/index.rst:1711: WARNING: duplicate jinja_ref description of to_entries, other instance in topics/jinja/index

/home/runner/work/salt/salt/doc/topics/jinja/index.rst:1714: WARNING: Title underline too short.

``from_entries``
--------------
/home/runner/work/salt/salt/doc/topics/jinja/index.rst:1714: WARNING: Title underline too short.

``from_entries``
--------------

@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 17:40 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 17:45 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 22:33 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 22:33 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 7, 2023 21:31 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 7, 2023 21:32 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 7, 2023 21:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 7, 2023 21:47 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 7, 2023 21:50 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 7, 2023 21:57 — with GitHub Actions Inactive
@s0undt3ch
s0undt3ch merged commit 245670f into saltstack:master Aug 14, 2023

This branch was previously deployed

1 inactive deployment
ci — 28236e30 Deployed Aug 7, 2023 by Ch3LL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MKLeb MKLeb Awaiting requested review from MKLeb MKLeb was automatically assigned from saltstack/team-core
3 more reviewers
@s0undt3ch s0undt3ch s0undt3ch approved these changes
@Ch3LL Ch3LL Ch3LL approved these changes
@cmcmarrow cmcmarrow cmcmarrow approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Chlorine v3007.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] implement jq-esque to_entries and from_entries functions

4 participants

@nicholasmhughes @s0undt3ch @Ch3LL @cmcmarrow