Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] implement jq-esque to_entries and from_entries functions #64602

Merged
merged 5 commits into from Aug 14, 2023
Merged

[master] implement jq-esque to_entries and from_entries functions #64602

merged 5 commits into from Aug 14, 2023

Conversation

nicholasmhughes
Copy link
Collaborator

@nicholasmhughes nicholasmhughes commented Jul 5, 2023 •
edited

What does this PR do?

see issue for details

What issues does this PR fix or reference?

Fixes: #64600

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner July 5, 2023 15:30
@nicholasmhughes nicholasmhughes requested review from MKLeb and removed request for a team July 5, 2023 15:30
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title implement jq-esque to_entries and from_entries functions [master] implement jq-esque to_entries and from_entries functions Jul 5, 2023
s0undt3ch
s0undt3ch previously approved these changes Jul 6, 2023
View reviewed changes
@s0undt3ch
Copy link
Member

The error preventing the CI run:

reading sources... [100%] topics/venafi/index .. topics/yaml/index                                                                                                                           
/home/runner/work/salt/salt/doc/topics/jinja/index.rst:1711: WARNING: duplicate jinja_ref description of to_entries, other instance in topics/jinja/index

/home/runner/work/salt/salt/doc/topics/jinja/index.rst:1714: WARNING: Title underline too short.

``from_entries``
--------------
/home/runner/work/salt/salt/doc/topics/jinja/index.rst:1714: WARNING: Title underline too short.

``from_entries``
--------------

@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 17:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 17:40 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 17:45 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 22:32 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 22:33 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 22:33 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci July 6, 2023 23:05 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:31 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:32 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:33 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:47 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:50 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:57 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch merged commit 245670f into saltstack:master Aug 14, 2023
321 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@cmcmarrow cmcmarrow cmcmarrow approved these changes

@MKLeb MKLeb Awaiting requested review from MKLeb MKLeb is a code owner automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Chlorine v3007.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] implement jq-esque to_entries and from_entries functions
4 participants
@nicholasmhughes @s0undt3ch @Ch3LL @cmcmarrow