-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[master][FEATURE REQUEST] Added support for dnf5 for Fedora #64675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
suggested changes
Jul 20, 2023
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
s0undt3ch
approved these changes
Jul 20, 2023
Ch3LL
approved these changes
Jul 20, 2023
Contributor
Ch3LL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a couple of questions that might be improvements. But I don't consider them a requirement to get this merged.
8 tasks
|
For anyone else who wondered what releases this pull request has already gone into: # git --no-pager log --all --grep='Added support for dnf5 for Fedora' --pretty='format:%H' | xargs -r -t -n1 git --no-pager tag --contains | sort -V
git --no-pager tag --contains 8f360e3cc9a2619aae58f1cac3f95259a9794b33
git --no-pager tag --contains 5fa7a865ab376f24b09bbe47157d99b1fe6a0847
v3007.0
v3007.0rc1
v3007.1 |
1 task
1 task
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
dnf5on Fedora.dnf5has changed options etc from the current versions ofdnf,for example:
--allowerasingis no longer a general option but tied to specific commands likeinstall.dnf5has changed other options too but has provided aliases to allow for backwards comparability,for example:
--disablerepo=REPO_ID,... Alias for '--disable-repo'What issues does this PR fix or reference?
Fixes: #64532
Previous Behavior
An install would fail since
--allowerasingprecedes theinstallcommandNew Behavior
install now succeeds as options such as
--allowerasingnow follow theinstallcommandMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.