Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master][FEATURE REQUEST] Added support for dnf5 for Fedora #64675

Merged
merged 11 commits into from Jul 20, 2023
Merged

[master][FEATURE REQUEST] Added support for dnf5 for Fedora #64675

merged 11 commits into from Jul 20, 2023

Conversation

dmurphy18
Copy link
Contributor

What does this PR do?

Adds support for dnf5 on Fedora.
dnf5 has changed options etc from the current versions of dnf,
for example: --allowerasing is no longer a general option but tied to specific commands like install.
dnf5 has changed other options too but has provided aliases to allow for backwards comparability,
for example: --disablerepo=REPO_ID,... Alias for '--disable-repo'

What issues does this PR fix or reference?

Fixes: #64532

Previous Behavior

An install would fail since --allowerasing precedes the install command

New Behavior

install now succeeds as options such as --allowerasing now follow the install command

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 added this to the Chlorine v3007.0 milestone Jul 20, 2023
@dmurphy18 dmurphy18 requested a review from a team as a code owner July 20, 2023 00:30
@dmurphy18 dmurphy18 requested review from Ch3LL and removed request for a team July 20, 2023 00:30
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [FEATURE REQUEST] Added support for dnf5 for Fedora [master][FEATURE REQUEST] Added support for dnf5 for Fedora Jul 20, 2023
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 01:08 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 01:08 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 01:09 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 01:25 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 01:28 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 04:46 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 07:51 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 07:51 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 07:51 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 07:51 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 07:51 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 07:51 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 08:23 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 08:23 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 08:23 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 08:23 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 08:23 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 08:23 — with GitHub Actions Inactive
s0undt3ch
s0undt3ch requested changes Jul 20, 2023
View reviewed changes
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
salt/modules/yumpkg.py Outdated Show resolved Hide resolved
dmurphy18 and others added 4 commits July 20, 2023 09:38
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
2131b5c 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
732edbe 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
849fb57 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
0349df1 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
dmurphy18 and others added 5 commits July 20, 2023 09:39
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
3a5c478 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
085e39a 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
90162b8 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@dmurphy18 @s0undt3ch
Update salt/modules/yumpkg.py
1a89a64 
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Updates due to reviewer suggestions
9d4f211
@dmurphy18 dmurphy18 requested a review from s0undt3ch July 20, 2023 15:49
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 16:20 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 16:20 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 16:25 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 16:27 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 16:38 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 16:41 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 17:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 17:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 17:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 17:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 17:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci July 20, 2023 17:55 — with GitHub Actions Inactive
Ch3LL
Ch3LL approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a couple of questions that might be improvements. But I don't consider them a requirement to get this merged.

salt/modules/yumpkg.py Show resolved Hide resolved
salt/modules/yumpkg.py Show resolved Hide resolved
@Ch3LL Ch3LL merged commit 75269c4 into saltstack:master Jul 20, 2023
322 checks passed
@dmurphy18 dmurphy18 deleted the fix_dnf5_64532 branch March 13, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Chlorine v3007.0
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] salt-minion pkg.* tasks fail if only dnf5 is present, not dnf
3 participants
@dmurphy18 @s0undt3ch @Ch3LL