Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Adding deprecation decorator to docker modules for 3009. #64890

Merged
merged 6 commits into from
Aug 28, 2023
Merged

[master] Adding deprecation decorator to docker modules for 3009. #64890

merged 6 commits into from
Aug 28, 2023

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Aug 1, 2023 •
edited
Loading

What does this PR do?

Adding deprecation decorator to docker modules for 3009.

What issues does this PR fix or reference?

Fixes: #64894

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner August 1, 2023 16:48
@garethgreenaway garethgreenaway requested review from cmcmarrow and removed request for a team August 1, 2023 16:48
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Adding deprecation decorator to docker modules for 3009. [master] Adding deprecation decorator to docker modules for 3009. Aug 1, 2023
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 17:05 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 17:05 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 17:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 17:26 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 17:27 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 17:28 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 22:28 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 22:29 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 22:43 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 22:47 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 23:33 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 1, 2023 23:34 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 01:56 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 01:56 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 01:56 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 01:56 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 01:56 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 01:56 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway added this to the Chlorine v3007.0 milestone Aug 2, 2023
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 23:33 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 23:33 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 23:34 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 2, 2023 23:34 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci August 10, 2023 17:00 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 17, 2023 21:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 17, 2023 21:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 17, 2023 21:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 17, 2023 21:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 17, 2023 21:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 17, 2023 21:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 18, 2023 02:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 18, 2023 02:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 18, 2023 02:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 18, 2023 02:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 18, 2023 02:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 18, 2023 02:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 18:51 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 18:51 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 18:51 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 18:51 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:07 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 24, 2023 19:20 — with GitHub Actions Inactive
whytewolf
whytewolf approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@whytewolf whytewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like standard Deprecation.

@Ch3LL Ch3LL merged commit 3880dae into saltstack:master Aug 28, 2023
321 checks passed
@SirRegion SirRegion mentioned this pull request Mar 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whytewolf whytewolf whytewolf approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@cmcmarrow cmcmarrow cmcmarrow approved these changes

@MKLeb MKLeb MKLeb approved these changes

Assignees
No one assigned
Labels
Chlorine v3007.0
Projects
None yet
Milestone
Chlorine v3007.0
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Deprecate Docker Modules
6 participants
@garethgreenaway @ITJamie @whytewolf @Ch3LL @cmcmarrow @MKLeb