[master] Account for included states that only include other states used as requisites #65326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgreenaway
requested review from
whytewolf
and removed request for
a team
salt-project-bot-prod-environment
bot
changed the title
whytewolf
previously approved these changes
Oct 2, 2023
whytewolf
previously approved these changes
Nov 22, 2023
s0undt3ch
previously requested changes
Nov 22, 2023
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
dmurphy18
approved these changes
Dec 8, 2023
dmurphy18
dismissed
s0undt3ch’s stale review
committed one suggestion and given the state of the team, leaving the tests where Gareth originally placed them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keep track when an included file only includes sls files but is a requisite.
What issues does this PR fix or reference?
Fixes: #65080
Previous Behavior
If the contents of an included state file only includes other state files that original state file cannot be used as a requisite.
New Behavior
Keep track of included files to ensure they can be used as requisites if they only include other state files.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.