Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3007.x] Update SSH wrappers, wrap more funcs #65517

Merged
merged 13 commits into from
Jan 2, 2024
Merged

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented Nov 6, 2023

What does this PR do?

  • Updates existing wrapper modules to be mostly in sync with the respective execution modules.
  • Wraps most cp.* functions.
  • Adds slsutil wrapper
  • Adds defaults wrapper
  • Adds log[mod] wrapper
  • Adds cmdmod wrapper for cmd.script
  • Makes cp.cache_file add the respective files to the filerefs archive that is sent to the minion during state runs

Based on #64576, which would have to be merged beforehand. Was merged.

Also substantially increases test coverage on the cp wrapper (Ref #64842). 23% -> >90%

Note: tests/pytests/integration/ssh/test_saltcheck.py::test_saltcheck_state is failing, but unrelated to this PR. git bisect shows it has been failing since 639ec02. -> reported as #65574

What issues does this PR fix or reference?

Fixes: #61100
Fixes: #56441
Fixes: #65067
Fixes: #61143
Fixes: #50196
Fixes: #48067
Fixes: #51605
Fixes: #65630

Partially: #61426
Helps with: #31531
Helps with: #19564

Previous Behavior

  • Confusing behavior when module calls behave differently via salt-ssh than usual
  • (see linked issues, many more would have been possible)
  • Jinja imports in managed file templates would fail. The workaround was to specify extra_filerefs before applying states, either via CLI param or in the Saltfile. This PR allows to declare those dependencies in the state files themselves.

New Behavior

Works mostly the same as regular Salt.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Update SSH wrappers, wrap more funcs [3006.x] Update SSH wrappers, wrap more funcs Nov 6, 2023
@dwoz dwoz changed the base branch from master to 3007.x January 2, 2024 21:17
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Update SSH wrappers, wrap more funcs [3007.x] Update SSH wrappers, wrap more funcs Jan 2, 2024
@dwoz dwoz merged commit 982ffba into saltstack:3007.x Jan 2, 2024
1424 of 1555 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment