Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Add deprecation warnings and release notes about setup.py #65525

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[master] Add deprecation warnings and release notes about setup.py #65525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb7b06d
Add deprecation warnings and release notes about ``setup.py``
s0undt3ch Nov 9, 2023
2731960
This is not yet true
s0undt3ch Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions doc/topics/releases/templates/3007.0.md.template
View file
Open in desktop
Expand Up @@ -6,8 +6,11 @@
Add release specific details below
-->

## Python 3.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should be given that Salt is two major releases behind. 3.11 brings some huge performance improvements

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.11 brings some huge performance improvements

Sadly, with regards to Salt, we saw exactly the opposite.

Salt's onedir packages now use Python 3.11
## Salt's ``setup.py`` customizations
> :warning: **Deprecation Notice**: <br>
In Salt 3009, the ``setup.py`` file will be stripped of it's custom additions and migrated to a plain ``pyproject.toml`` python package
or whatever is found best during the process of removing the customizations. <br>
**If you're relying on these customizations please stop as your workflow will break in the future**.

## Python 3.7 Support Dropped
Support for python 3.7 has been dropped since it reached end-of-line in 27 Jun 2023.
Expand Down
5 changes: 5 additions & 0 deletions setup.py
View file
Open in desktop
Expand Up @@ -1225,4 +1225,9 @@ def parse_command_line(self):
warnings.warn(
"Warning: distutils is deprecated and shall be removed in Python 3.12, advise migrate to using setuptools"
)
warnings.warn(
"In Salt 3009, the `setup.py` file will be stripped of it's custom additions and migrated to a plain "
"`pyproject.toml` python package or whatever is found best during the process of removing the customizations. "
"If you're relying on these customizations please stop as your workflow will break in the future."
)
setup(distclass=SaltDistribution)