[3006.x] Migrate to TZ-aware datetime objects in x509_v2 #65838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
lkubb
force-pushed
the
x509-v2-utcnow
branch
2 times, most recently
from
7081754
to
c3263cf
Compare
s0undt3ch
approved these changes
Apr 26, 2024
|
@dwoz Anything holding this up? It should be quite straight-forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
datetime.utcnowwithdatetime.now(tz=timezone.utc)What issues does this PR fix or reference?
Fixes: #65837
Ref: #65604
Previous Behavior
CRLs were created with wrong timestamps, Python 3.12 would log DeprecationWarnings
New Behavior
Correct CRL timestamps, no warnings
Merge requirements satisfied?
- not sure how to test the issue reliably tbh. A regression is unlikely since we're dealing in TZ-aware datetimes only now.Commits signed with GPG?
Yes