Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Initial purge of community extensions #65971

Merged
merged 6 commits into from Apr 11, 2024

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 31, 2024

What does this PR do?

Initial purge of community extensions for 3008

#65970

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested a review from a team as a code owner January 31, 2024 21:27
@dwoz dwoz requested review from whytewolf and removed request for a team January 31, 2024 21:27
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Initial purge of community extensions [master] Initial purge of community extensions Jan 31, 2024
@dwoz dwoz changed the title [master] Initial purge of community extensions [wip] [master] Initial purge of community extensions Jan 31, 2024
@max-arnold
Copy link
Contributor

max-arnold commented Feb 1, 2024

Things that seem useful to keep in core (esp. sqlite modules, nacl modules, pkg runner, aptpkg/denconfmod states, rsync state):

engines:
stalekey.py <============== Useful for Cloud environments where minions come and go

modules:
smtp

output:
profile

pillar:
cmd_yaml <===============
cmd_json <==============
http_yaml
http_json
nacl
sqlite3 <===============

queues:
pgjsonb_queue
sqlite_queue <================

renderers:
pydsl

returners:
smtp_return
sqlite3_return <===================

runners:
nacl
pkg <===================
thin <???????? Salt-ssh?

sdb:
cache
rest
sqlite3 <===============

serializers:
keyvalue

states:
aptpkg <===================
debconfmod <==============
ethtool
kernelpkg
rsync <==================
smtp
sqlite3 <==================
xml

Alternatively, what is the process to get them back into core, if there is a significant demand?

@dwoz dwoz force-pushed the community-extension-purge branch 2 times, most recently from a4dd4af to 18b4347 Compare February 2, 2024 01:04
@dwoz dwoz added this to the Argon v3008.0 milestone Feb 2, 2024
- Add back cmd_json and cmd_yaml pillars for test fixes
- Remove broken tests and bump cache seed
- Fix filemap
- Restrict pyzmq to <25.1.1
- Fix pkg tests
- Fix performance test
- skip tests that failed due to zypperpkg module removal
- Fix tmp path so test passes on windows
- Remove files accidently added
@dwoz dwoz force-pushed the community-extension-purge branch from 8d5c330 to 7a0e8cc Compare April 8, 2024 20:31
@dwoz dwoz changed the title [wip] [master] Initial purge of community extensions [master] Initial purge of community extensions Apr 8, 2024
@dwoz
Copy link
Contributor Author

dwoz commented Apr 8, 2024

Alternatively, what is the process to get them back into core, if there is a significant demand?

At this point it's very unlikely that anything removed by this PR will get added back in. If there is anything out of this list that is useful then there should be sufficient enough motivation for someone other than the core team to maintain a salt extension. Even if something is deemed to be worth of being supported further by the core team. We'd make an extension rather than adding it back into Salt. The one outlier I can think of would be we find a significant bug caused by something that has been removed.

Copy link
Member

@thatch45 thatch45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

@dwoz dwoz merged commit aad71fd into saltstack:master Apr 11, 2024
241 checks passed
@KartikShrikantHegde
Copy link

Hi @dwoz , what would be the tentative timeline for 3008 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite test:pkg Run the package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants