Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x][BACKPORT] Fix utf8 handling in 'pass' renderer and make it more robust #64300 #66033

Merged
merged 2 commits into from
Jun 21, 2024
Merged

[3006.x][BACKPORT] Fix utf8 handling in 'pass' renderer and make it more robust #64300 #66033

merged 2 commits into from
Jun 21, 2024

Conversation

mbebjak
Copy link

@mbebjak mbebjak commented Feb 9, 2024

What does this PR do?

Backports fixes from #64300

What issues does this PR fix or reference?

Fixes: #65349

@mbebjak mbebjak requested a review from a team as a code owner February 9, 2024 08:35
@mbebjak mbebjak requested review from whytewolf and removed request for a team February 9, 2024 08:35
@welcome Welcome
Copy link

welcome bot commented Feb 9, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@mbebjak mbebjak mentioned this pull request Feb 9, 2024
Open
9 tasks
@dwoz dwoz added the test:full Run the full test suite label Feb 14, 2024
dwoz
dwoz requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@dwoz dwoz added this to the Sulfur v3006.7 milestone Feb 14, 2024
@mbebjak
Copy link
Author

mbebjak commented Feb 15, 2024

@dwoz rebased

@jbartak
Copy link

jbartak commented Feb 27, 2024

Any update please?
@dwoz

@dwoz dwoz merged commit 3bc6e3a into saltstack:3006.x Jun 21, 2024
87 of 89 checks passed
@welcome Welcome
Copy link

welcome bot commented Jun 21, 2024

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@whytewolf whytewolf Awaiting requested review from whytewolf whytewolf was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
test:full Run the full test suite
Projects
None yet
Milestone
Sulfur v3006.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mbebjak @jbartak @dwoz @dmach