Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3007.x] Change log level of successful master cluster key exchange from error to info #66267

Merged
merged 2 commits into from Apr 10, 2024

Conversation

clayoster
Copy link
Contributor

@clayoster clayoster commented Mar 24, 2024

What does this PR do?

Sets the log level of successful master key exchange from error to info.

What issues does this PR fix or reference?

Fixes: #66266

Previous Behavior

Logs indicating successful master key exchange would be logged as errors

New Behavior

These logs will not be seen unless the master is running with a log_level of info

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@clayoster clayoster requested a review from a team as a code owner March 24, 2024 19:33
@clayoster clayoster requested review from Akm0d and removed request for a team March 24, 2024 19:33
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Change log level of successful master cluster key exchange from error to debug [3007.x] Change log level of successful master cluster key exchange from error to debug Mar 24, 2024
@whytewolf
Copy link
Contributor

so, 2 things. first I don't think this should be debug. info maybe. as this important information to have beyond debugging purposes. one could even argue for warning as this isn't an error but a warning of where the information is going.

second it does need tests to make sure it is logging at the correct level.

@clayoster
Copy link
Contributor Author

@whytewolf - Thanks for the input, I do think info makes more sense. I'll update the PR accordingly and find some time to work on tests.

@clayoster clayoster changed the title [3007.x] Change log level of successful master cluster key exchange from error to debug [3007.x] Change log level of successful master cluster key exchange from error to info Mar 27, 2024
@dwoz dwoz merged commit 622365a into saltstack:3007.x Apr 10, 2024
501 of 502 checks passed
@clayoster clayoster deleted the master-cluster-error-logs branch April 10, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants