Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Remove firing useless event and not related comment #66279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vzhestkov
Copy link
Contributor

What does this PR do?

There is a useless event fired and the comment which doesn't seem really related to this operation.
It was introduced long time ago with c131c09
and just issuing the following:

20240327120237373936	{"minions": ["evil-004991.demo.org", "evil-004992.demo.org", "evil-004993.demo.org", "evil-004994.demo.org"], "_stamp": "2024-03-27T12:02:37.375454"}

in combination with meaningful:

salt/job/20240327120237373936/new	{"jid": "20240327120237373936", "tgt_type": "list", "tgt": ["evil-004991.demo.org", "evil-004992.demo.org", "evil-004993.demo.org", "evil-004994.demo.org"], "user": "admin", "fun": "test.arg", "arg": [], "minions": [""evil-004991.demo.org", "evil-004992.demo.org", "evil-004993.demo.org", "evil-004994.demo.org"], "missing": [], "_stamp": "2024-03-27T12:02:37.375807"}

What issues does this PR fix or reference?

Tracks: https://github.com/SUSE/spacewalk/issues/23526

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@vzhestkov vzhestkov requested a review from a team as a code owner March 27, 2024 12:43
@vzhestkov vzhestkov requested review from Akm0d and removed request for a team March 27, 2024 12:43
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Remove firing useless event and not related comment [master] Remove firing useless event and not related comment Mar 27, 2024
@Akm0d
Copy link
Contributor

Akm0d commented Mar 27, 2024

What is the justification for removing this event? Besides you not having a use for it, Is it causing problems somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants