-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] New pem managed state #66322
base: master
Are you sure you want to change the base?
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
Can someone point me how to solve problems in pipeline please? |
I think you also need to add it to |
I think all we need now is a changelog. |
It was not working as expected when passing content and also some errors with cryptography package were not catched. Now it should be more stable. Thank you for your time spent on this. |
We'll be discussing this in our Standup Today. We have moved many modules out of Salt to be supported by the community as Salt Extensions. This may be a candidate for a Salt Extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this contribution would be better made as a salt extension rather than landing in the core Salt codebase.
I am little bit lost, where should I contribute this code as part of salt extension. New repository should be created, or contribute to any of existing one https://github.com/orgs/salt-extensions/repositories ? |
I think this would be a new repository in the salt-extensions org. @nicholasmhughes can create it and make you the maintainer |
…l info in the comment
What does this PR do?
Create new state that will handle certificates as files and provide easier management with few conditions and human readable info in the comment. Under the hood use standard
file.managed
state to provide any necessary and already implemented magic.Reason for this state is easier management of files with PEM formats (certificates), which can hold just one certificate or combinations of privkey->certificate->chain
Requirement is cryptography package, which is checked. Maybe few more conditions and informations to the output comment can be add later. E.g if chain is detected, then right order of chain is required with another condition check.
This provides easy and quick status to any admin dealing with certificate files which he already have at hand.
Name of the module
pem
can be certainly changed if required but is relatively appropriate.Examples
No changes - certificates are same
Certificates are not the same - test=true
Certificates do not pass conditions
Merge requirements satisfied?
Commits signed with GPG?
No