[3007.x] Don't unnecessarily download remote sources to cache #66343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
lkubb
force-pushed
the
file-managed-unnecessary-download
branch
from
6ace31a
to
2d77487
Compare
lkubb
force-pushed
the
file-managed-unnecessary-download
branch
from
2d77487
to
de9a0f9
Compare
lkubb
force-pushed
the
file-managed-unnecessary-download
branch
from
5353102
to
109dd48
Compare
|
@lkubb Can you please backport this too? |
|
@dwoz Sure. :) |
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
file.managedcheck if an existing file's contents match the expected ones early (for remote sources with known source_hash). If they do, forcesreplaceto false and thus skips fetching the file to cache.What issues does this PR fix or reference?
Fixes: #66342
Ref: #64373
Previous Behavior
Essentially manages both intended file and file in cache, wastes resources.
New Behavior
Only manages intended file.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes