[3006.x] fix win_task ExecutionTimeLimit and result/error code interpretation #66442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecutionTimeLimit: can be nothing or "PT0S" if not used _reverse_lookup: if not found, return "invalid value" instead of the last dict element
correct high result/error code numbers that are returned as negative numbers by win32com. handle unknown LastTaskResult result codes.
|
@hurzhurz is there any possibility you can write a regression test for this change? |
hurzhurz
force-pushed
the
3006.x-wintask-fixes
branch
from
7a4b563
to
de651d6
Compare
|
@dwoz ok, I gave it a try and wrote some tests. please have a look |
dwoz
approved these changes
Jun 21, 2024
twangboy
approved these changes
Jun 28, 2024
dmurphy18
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes #66347, #66441