-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Prevent using SyncWrapper with no reason #66510
Open
vzhestkov
wants to merge
1
commit into
saltstack:master
Choose a base branch
from
vzhestkov:prevent-using-sync-wrapper
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Prevent using SyncWrapper with no reason
[master] Prevent using SyncWrapper with no reason
May 13, 2024
vzhestkov
force-pushed
the
prevent-using-sync-wrapper
branch
from
May 13, 2024 12:56
45e1737
to
653bf4d
Compare
3 tasks
@vzhestkov |
@vzhestkov ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's not really clear if it was mate intentionally or just the parameter is missing by accident here.
Due to missing
io_loop
paramerer it's causing setting_run_io_loop_sync
toTrue
inSaltEvent
object with:salt/salt/utils/event.py
Lines 231 to 236 in e5eee2f
And that's why is using
salt.utils.asynchronous.SyncWrapper
here:salt/salt/utils/event.py
Lines 322 to 331 in e5eee2f
What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/23526
Previous Behavior
SaltEvent is using
salt.utils.asynchronous.SyncWrapper
with the code which is intended to be used inasync
way.New Behavior
salt.utils.asynchronous.SyncWrapper
is not used, but directasync
calls are used instead.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.